Closed Bug 1652829 Opened 5 years ago Closed 5 years ago

Re-enable browser/components/search/test/browser/browser_google_behavior.js test for Fission

Categories

(Firefox :: Search, defect, P3)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Project Flags:
Fission Milestone M4.1

People

(Reporter: cpeterson, Unassigned)

References

Details

Bug 1617983 disabled the browser_google_behavior.js test for debug Fission:

https://searchfox.org/mozilla-central/rev/82c04b9cad5b98bdf682bd477f2b1e3071b004ad/browser/components/search/test/browser/browser.ini#36-37

[browser_google_behavior.js]
skip-if = (fission && debug) # Bug 1614268 (see also bug 1617983 comment 9)

Bug 1617983 comment 9 blames nsFocusManager::SetFocus bug 1556627:

So what I've been able to figure out is that by calling focus on the search input element here: https://searchfox.org/mozilla-central/rev/91f6c02fcf4c16f78fdc4417f61f192688294066/browser/components/search/test/browser/browser_google_behavior.js#171

We ultimately cause the shutdown leak to occur.

Also, this seems to only be true since bug 1556627 landed. If I check out the previous commit, fad5300d47a8, and enable the privileged about content process, I don't get the leak anymore.

SetFocus bug 1556627 has been fixed since bug 1617983 comment 9, so perhaps we just need to re-enable this test.

Kashav has a patch to re-enable this test in bug 1653674.

Depends on: 1653674
Severity: -- → S4
Priority: -- → P3

Fixed in 1653674

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.