Closed Bug 1653024 Opened 4 years ago Closed 3 years ago

Ship Intl.DateTimeFormat.prototype.formatRange and .formatRangeToParts to release

Categories

(Core :: JavaScript: Internationalization API, task, P2)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mconca, Assigned: anba)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Per comment 16 in bug 1496584:

The spec has two issues I'd like to see resolved before letting this feature ride to release:

There's https://github.com/tc39/proposal-intl-DateTimeFormat-formatRange/issues/21 which means the spec as-is doesn't do the correct thing at all. I've added some comments how it could be fixed, but nobody seems to have looked into that one yet.

And I'm not sure how people feel about https://github.com/tc39/proposal-intl-DateTimeFormat-formatRange/issues/22. Proposal champions and reviewers need to chime in there, too.

Once those issues are resolved, we should ship to release.

Severity: -- → N/A

The second of those issues is resolved now, so only the first issue remains. Sounds like that's waiting on anba to respond to review comments, and for Frank Yung-Fong Tang to comment/review some as well, and then that PR can land, the issue can be closed, and we'd be ready to ship.

anba, mind looking at the review in that issue? Sounds like that's the only thing in the way of formatRange moving forward in the spec process, and our shipping it as well.

Flags: needinfo?(andrebargull)

First we need to update to ICU 68, because it fixes a couple of formatRange issues and it will also make it easier to test if our implementation matches the spec and it will help me to review the spec, too.

Flags: needinfo?(andrebargull)
Depends on: 1686052
Priority: -- → P2
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/acab81c6317d Part 1: Enable Intl.DateTimeFormat.prototype.formatRange by default. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/d70c3d846c39 Part 2: Enable test262 feature for Intl.DateTimeFormat.prototype.formatRange by default. r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

FYI only, FF91 documentation for this can be tracked in https://github.com/mdn/content/issues/6710. This had pretty much already been done, so all this required was a minor tidy of docs, update to browser compatibility and a release note

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: