1653030 - "All" optimization strategy should return False as soon as one of its substrategies returns False

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, enhancement)

Description

[Marco Castelluccio [:marco]]

Currently, all substrategies are evaluated before returning.

E.g. this would help on backstop pushes when you have a strategy such as:

    All(
        "backstop"
        "bugbug-reduced-fallback",
    )

since on such pushes the "bugbug-reduced-fallback" wouldn't need to be evaluated.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Bug 1653030 - Make 'All' optimization strategy return early as soon as one of its substrategies returns False. r=ahal

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4d91130e5ef
Make 'All' optimization strategy return early as soon as one of its substrategies returns False. r=ahal

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Bug 1653030 - Use Python's not operator

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c24a785142fb
Use Python's not operator

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b4d91130e5ef
https://hg.mozilla.org/mozilla-central/rev/c24a785142fb