1653061 - turn on 7 rows of pocket stories in the de locale

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1653061 - turn on 7 rows of pocket stories in the de locale

Comment 2

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: (just a pref flip) There are revenue implications here, and we just go the green light to turn this on. Getting it out asap, if possible, would be great. It's a really low risk to no risk patch.

Comment 3

[Scott [:thecount] Downe]

Comment on attachment 9163849 [details]
Bug 1653061 - turn on 7 rows of pocket stories in the de locale

Beta/Release Uplift Approval Request

• User impact if declined: There is a revenue impact to this.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

1. Set browser.search.region to DE
2. Restart
3. Set browser.newtabpage.activity-stream.feeds.system.topstories to true
4. Restart

You can also:

1. Download a German browser
2. Set browser.search.region to DE if you're no physically in Germany
3. Restart

You should see 7 rows of pocket stories on a new newtab.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a single pref flip to a value that's already used for US release.

We've also experimented with this value with no found issues.

• String changes made/needed: none

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/412a50c5fc4c
turn on 7 rows of pocket stories in the de locale r=gvn

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/412a50c5fc4c

Comment 6

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the browser.newtabpage.activity-stream.discoverystream.region-layout-config pref is changed to include DE by default (US,CA,GB,DE) using the builds from Bogdan's pushlog on Windows 10 x64, macOS 10.15, and Ubuntu 18.04.

Sadly, this early on we do not have access to a localized Nightly build or a compatible language pack to see that the change is made on the New Tab page, but given that we have previously used this pref in an experiment we should consider this as verified and uplift to Beta. Once it is uplifted in Beta we will re-verify the change using a localized Firefox build and mark it as such.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9163849 [details]
Bug 1653061 - turn on 7 rows of pocket stories in the de locale

Approved for 79.0b9.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8a9ef4d88452

Comment 9

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Marking this issue as verified on the latest Beta 79.0b9 based on the test suite that we ran on Windows 10, macOS 10.15, and Ubuntu 18.04.