Closed Bug 1653103 Opened 3 months ago Closed 3 months ago

Consider removing mDocShellAs* and mWebProgress from nsWebBrowser

Categories

(Core :: DOM: Navigation, task)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: edgar, Assigned: edgar)

Details

Attachments

(3 files)

We could remove those interface pointers by holding nsDocShell in nsWebBrowser directly.

Summary: Remove mDocShellAs* and mWebProgress from nsWebBrowser → Consider removing mDocShellAs* and mWebProgress from nsWebBrowser

And make nsWebBrowser::SetDocShell return void.

Depends on D83707

Assignee: nobody → echen
Status: NEW → ASSIGNED
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fff596051135
Part 1: Make nsWebBrowser::InternalDestroy return void; r=nika
https://hg.mozilla.org/integration/autoland/rev/fac9fa6d69c3
Part 2: Make nsWebBrowser::EnsureDocShellTreeOwner return void; r=nika
https://hg.mozilla.org/integration/autoland/rev/ad1b28452511
Part 3: Remove mDocShellAs* and mWebProgress from nsWebBrowser; r=nika
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.