1653103 - Consider removing mDocShellAs* and mWebProgress from nsWebBrowser

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Description

[Edgar Chen [:edgar]]

We could remove those interface pointers by holding nsDocShell in nsWebBrowser directly.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1653103 - Part 1: Make nsWebBrowser::InternalDestroy return void;

Comment 2

[Edgar Chen [:edgar]]

Attachment: Bug 1653103 - Part 2: Make nsWebBrowser::EnsureDocShellTreeOwner return void;

Depends on D83706

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1653103 - Part 3: Remove mDocShellAs* and mWebProgress from nsWebBrowser;

And make nsWebBrowser::SetDocShell return void.

Depends on D83707

Comment 4

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c5fe1cfe5378da6e39b1f655385699a84a17fbd

Comment 5

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8147ee9a4a878b6194a5e3eb8aaf61af3e336c4

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fff596051135
Part 1: Make nsWebBrowser::InternalDestroy return void; r=nika
https://hg.mozilla.org/integration/autoland/rev/fac9fa6d69c3
Part 2: Make nsWebBrowser::EnsureDocShellTreeOwner return void; r=nika
https://hg.mozilla.org/integration/autoland/rev/ad1b28452511
Part 3: Remove mDocShellAs* and mWebProgress from nsWebBrowser; r=nika

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/fff596051135
https://hg.mozilla.org/mozilla-central/rev/fac9fa6d69c3
https://hg.mozilla.org/mozilla-central/rev/ad1b28452511