1653164 - Show WebGPU adapter strings in `about:support`

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, enhancement)

Description

[Dzmitry Malyshau [:kvark]]

We have a lot of information about WebGL1/2. It would make sense to add something for WebGPU.

Comment 1

[Kelsey Gilbert [:jgilbert]]

We want the equivalent of webgl's lines in about:support:

WebGL 1 Driver Renderer | Google Inc. (Intel) -- ANGLE (Intel, Intel(R) Arc(TM) A770 Graphics Direct3D11 vs_5_0 ps_5_0, D3D11-31.0.101.4314)

We don't want to expose this info to web content yet, so we'll restrict access to privileged contexts, like webgl does.

Comment 2

[Kelsey Gilbert [:jgilbert]]

In webgpu's case, we do want to integrate it into the existing object json thing, though.

Comment 3

[Erich Gubler [:ErichDonGubler]]

From internal chat with :jgilbert: Basically, we want readable contents of wgpu's AdapterInfo, which is accessible via Adapter::get.

Comment 4

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1653164: feat(webgpu): show `wgpu*` fields for WebGPU adapters in `about:support` r=#webgpu-reviewers

Comment 5

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1653164: fix(webgpu): actually show props. for `adapter.requestAdapterInfo()` in `about:support` r=#webgpu-reviewers

Comment 6

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1653164: refactor(webgpu): fix `WGPUTextureDescriptor` naming r=#webgpu-reviewers

Depends on D177402

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a996e5517aa1
fix(webgpu): actually show props. for `adapter.requestAdapterInfo()` in `about:support` r=webgpu-reviewers,jgilbert
https://hg.mozilla.org/integration/autoland/rev/32ca1ab63d70
feat(webgpu): show `wgpu*` fields for WebGPU adapters in `about:support` r=webgpu-reviewers,webidl,saschanaz,jgilbert
https://hg.mozilla.org/integration/autoland/rev/037d37f4eb71
refactor(webgpu): fix `WGPUTextureDescriptor` naming r=webgpu-reviewers,jgilbert

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for causing builds bustages in Adapter.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: builds/worker/checkouts/gecko/dom/webgpu/Adapter.cpp(144,12): error: no member named 'features' in 'std::shared_ptr<mozilla::webgpu::ffi::WGPUAdapterInformation>'; did you mean to use '->' instead of '.'?

Comment 9

[Erich Gubler [:ErichDonGubler]]

Sigh, looks like the patches from bug 1830336 conflicted, will land again.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/984a479a81d8
fix(webgpu): actually show props. for `adapter.requestAdapterInfo()` in `about:support` r=webgpu-reviewers,jgilbert
https://hg.mozilla.org/integration/autoland/rev/86be7d9d8fa1
feat(webgpu): show `wgpu*` fields for WebGPU adapters in `about:support` r=webgpu-reviewers,webidl,saschanaz,jgilbert
https://hg.mozilla.org/integration/autoland/rev/6f36f0a844be
refactor(webgpu): fix `WGPUTextureDescriptor` naming r=webgpu-reviewers,jgilbert

Comment 11

[Narcis Beleuzu [:NarcisB]]

Backed out for build bustages on Adapter.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/cfae5bf87989372b2a0b9374e0e564f9340b81b7
Log link: https://treeherder.mozilla.org/logviewer?job_id=415144539&repo=autoland&lineNumber=16078

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91185e96b467
fix(webgpu): actually show props. for `adapter.requestAdapterInfo()` in `about:support` r=webgpu-reviewers,jgilbert
https://hg.mozilla.org/integration/autoland/rev/1b25345f09e5
feat(webgpu): show `wgpu*` fields for WebGPU adapters in `about:support` r=webgpu-reviewers,webidl,saschanaz,jgilbert
https://hg.mozilla.org/integration/autoland/rev/938fa5409a7a
refactor(webgpu): fix `WGPUTextureDescriptor` naming r=webgpu-reviewers,jgilbert

Comment 13

[Serban Stanca [:SerbanS]]

Backed out for causing bp-nu bustages in Adapter.h.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/webgpu/Adapter.h:41:14: error: no template named 'shared_ptr' in namespace 'std'

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/897e87970bee
fix(webgpu): actually show props. for `adapter.requestAdapterInfo()` in `about:support` r=webgpu-reviewers,jgilbert
https://hg.mozilla.org/integration/autoland/rev/870902dd4347
feat(webgpu): show `wgpu*` fields for WebGPU adapters in `about:support` r=webgpu-reviewers,webidl,saschanaz,jgilbert
https://hg.mozilla.org/integration/autoland/rev/9c94ab8b34c0
refactor(webgpu): fix `WGPUTextureDescriptor` naming r=webgpu-reviewers,jgilbert

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/897e87970bee
https://hg.mozilla.org/mozilla-central/rev/870902dd4347
https://hg.mozilla.org/mozilla-central/rev/9c94ab8b34c0