Closed
Bug 1653214
Opened 5 years ago
Closed 5 years ago
Consider removing nsIBaseWindow::Create
Categories
(Core :: DOM: Navigation, task)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: edgar, Assigned: edgar)
Details
Attachments
(2 files)
We could consider removing nsIBaseWindow::Create, https://searchfox.org/mozilla-central/rev/82c04b9cad5b98bdf682bd477f2b1e3071b004ad/widget/nsIBaseWindow.idl#74.
Most of the classes that inherit nsIBaseWindow don't implement Create(), except nsDocShell. For nsDocShell, we could merge the implementation of Create() into InitWindow(), then nsIBaseWindow::Create could be removed.
(Not sure if DOM: Navigation is the right component for this)
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D83766
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → echen
Status: NEW → ASSIGNED
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4f052db0d024
Part 1: Merge implementations of nsDocShell::Create into nsDocShell::InitWindow; r=nika
https://hg.mozilla.org/integration/autoland/rev/532a0eab97c1
Part 2: Remove nsIBaseWindow::Create; r=nika
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4f052db0d024
https://hg.mozilla.org/mozilla-central/rev/532a0eab97c1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in
before you can comment on or make changes to this bug.
Description
•