1653254 - [wpt-sync] Sync PR 24626 - [css-grid] Clear size override in MinLogicalSizeForChild if needed

Status: RESOLVED FIXED

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24626 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24626
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

[css-grid] Clear size override in MinLogicalSizeForChild if needed

Grid items can get an override for their containing block size, which
for example can affect percentage resolution.
However, sometimes we need to clear such overrides, which can be checked
using ShouldClearOverrideContainingBlockContentSizeForChild.
That's already done in LogicalHeightForChild, used by MinContentForChild
and MaxContentForChild.

But when the min track sizing function is 'auto', the code may use
MinLogicalSizeForChild instead of LogicalHeightForChild. And
MinLogicalSizeForChild didn't check if the override had to be cleared.

This patch makes it perform the check.

Bug: 1103592
Change-Id: Ie6012b5099c4988217228352dc552f7437f738d2
Reviewed-on: https://chromium-review.googlesource.com/2299354
WPT-Export-Revision: 0b4bcdd357cd2db8bfc25ff25287f42f256e268f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=592f8e5b3104bc6693bfc55cb6e2b2c5c5fd9f95

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
PASS: 9

Chrome

OK : 1
PASS: 6
FAIL: 3

Safari

OK : 1
PASS: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62030a451f2c
[wpt PR 24626] - [css-grid] Clear size override in MinLogicalSizeForChild if needed, a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/62030a451f2c