1653421 - Add data to text value change events in mac

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

In order to hear key echos as current word typed in VoiceOver, we need to send data with the accessibility notification. This is a dictiuonary object with the following structure:

• AXTextChangeElement: The source element of the change (ie. the text control).
• AXTextStateChangeType: A member of the AXTextStateChangeType enum. This should be AXTextStateChangeTypeEdit for text editing.
• AXTextChangeValues: This is an array of changes represented in this event. There can be several changes in one event, for example a paste that replaces text would have a delete followed by an insertion. Our text events don't support that. So it will always be a single element list.
  • AXTextEditType: A member of the AXTextEditType enum. There may be a need for more nuance in the future, but for now insertions should be AXTextEditTypeTyping and deleting should be AXTextEditTypeDelete.
  • AXTextChangeValue: The string delta representing the change
  • AXTextChangeValueStartMarker: A text marker at the start of the insertion/deletion.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1653421 - Part 1: Refactor AccessibleWrap event handling. r?morgan

I split the switch statement into two: the first switch determines the
MOX target accessible. The second one does all the rest. This makes it more
readable and scalable when we add more events that need to be accompanied with
data.

Depends on D83680

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1653421 - Part 2: Add attributed string for range getter. r?morgan

This doesn't actually add any attributes yet.
VoiceOver uses this instead of the plain string equivalent.

Depends on D84053

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1653421 - Part 3: Don't normalize marker beyond editable root. r?morgan

When in an editable container, text markers are expected to not go past or before the editable root.

Depends on D84054

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1653421 - Part 4: Pass data with text value change events.

Depends on D84055

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1653421 - Part 5: Add xpc mac event interface so we can include data. r?morgan

Depends on D84056

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1653421 - Part 6: Introduce tests for text change events. r?morgan

Depends on D84057

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daeda032926d
Part 1: Refactor AccessibleWrap event handling. r=morgan
https://hg.mozilla.org/integration/autoland/rev/1d37ebf3d20c
Part 2: Add attributed string for range getter. r=morgan
https://hg.mozilla.org/integration/autoland/rev/5972532c7737
Part 3: Don't normalize marker beyond editable root. r=morgan
https://hg.mozilla.org/integration/autoland/rev/f8de624ccd8a
Part 4: Pass data with text value change events. r=morgan
https://hg.mozilla.org/integration/autoland/rev/cec6fc78de0e
Part 5: Add xpc mac event interface so we can include data. r=morgan
https://hg.mozilla.org/integration/autoland/rev/88708e164b1a
Part 6: Introduce tests for text change events. r=morgan

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/daeda032926d
https://hg.mozilla.org/mozilla-central/rev/1d37ebf3d20c
https://hg.mozilla.org/mozilla-central/rev/5972532c7737
https://hg.mozilla.org/mozilla-central/rev/f8de624ccd8a
https://hg.mozilla.org/mozilla-central/rev/cec6fc78de0e
https://hg.mozilla.org/mozilla-central/rev/88708e164b1a

Comment 9

[Marco Zehe (:MarcoZ)]

Eitan, can you take a look?