Closed
Bug 1653429
Opened 5 years ago
Closed 5 years ago
moz-phab patch --raw should include patch metadata
Categories
(Conduit :: moz-phab, defect, P3)
Conduit
moz-phab
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: erahm, Assigned: glob)
Details
(Keywords: conduit-triaged)
Attachments
(1 file)
Currently moz-phab patch --raw ...
does not include patch metadata such as author, commit message, etc that is useful for importing into a hg or git repo. Ideally I'd expect to see whatever the patch would look like if we sent it to lando (so updated reviewers etc).
For example the current behavior:
vrångö:kaios erahm$ moz-phab patch --raw D83718
diff --git a/.taskcluster.yml b/.taskcluster.yml
--- a/.taskcluster.yml
+++ b/.taskcluster.yml
@@ -194,7 +194,7 @@
# run-task uses these to check out the source; the inputs
# to `mach taskgraph decision` are all on the command line.
$merge:
- - GECKO_BASE_REPOSITORY: 'https://hg.mozilla.org/mozilla-unified'
+ - GECKO_BASE_REPOSITORY: 'https://hg.mozilla.org/projects/kaios'
GECKO_HEAD_REPOSITORY: '${repoUrl}'
GECKO_HEAD_REF: '${push.revision}'
GECKO_HEAD_REV: '${push.revision}'
And the behavior of hg export
:
vrångö:kaios erahm$ hg export 514db9c504b4
# HG changeset patch
# User Eric Rahm <erahm@mozilla.com>
# Date 1594830372 25200
# Wed Jul 15 09:26:12 2020 -0700
# Node ID 514db9c504b4ae4a3141b79752159e61aa984ce6
# Parent 3f4385713d11990f0a357df17217b568cd4473eb
Bug 1653090 - Use kaios project for taskcluster decision task. r=tomprince
Switches the GECKO_BASE_REPOSITORY for taskcluster to point the the kaios project branch.
Differential Revision: https://phabricator.services.mozilla.com/D83718
diff --git a/.taskcluster.yml b/.taskcluster.yml
--- a/.taskcluster.yml
+++ b/.taskcluster.yml
@@ -194,7 +194,7 @@ tasks:
# run-task uses these to check out the source; the inputs
# to `mach taskgraph decision` are all on the command line.
$merge:
- - GECKO_BASE_REPOSITORY: 'https://hg.mozilla.org/mozilla-unified'
+ - GECKO_BASE_REPOSITORY: 'https://hg.mozilla.org/projects/kaios'
GECKO_HEAD_REPOSITORY: '${repoUrl}'
GECKO_HEAD_REF: '${push.revision}'
GECKO_HEAD_REV: '${push.revision}'
Reporter | ||
Comment 1•5 years ago
|
||
This adds metaata to the outuput for moz-phab patch --raw
that is
suitable for using with hg import
. Proper git
formatting is left as
an excercise for someone who uses git
.
Updated•5 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Updated•5 years ago
|
Keywords: conduit-triaged
Priority: -- → P3
Updated•5 years ago
|
Attachment #9164196 -
Attachment description: Bug 1653429 - Include metadata in raw patches. r=zalun! → Bug 1653429 - moz-phab patch --raw should include patch metadata; r=zeid
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•