Remove unused "geo.provider-country.network.scan" pref
Categories
(Core :: DOM: Geolocation, enhancement, P5)
Tracking
()
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: daleharvey, Assigned: elainen98, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(2 files)
758 bytes,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
https://searchfox.org/mozilla-central/source/dom/system/NetworkGeolocationProvider.jsm#273
This was from before we moved the region fetching into Region.jsm
Assignee | ||
Comment 1•5 years ago
|
||
Hello, can I contribute to this?
Reporter | ||
Comment 2•5 years ago
|
||
Hi Elaine
Sure you can, I have assigned it to you. There are instructions @ https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html to get up and running and if you have any questions, #introductions in chat.mozilla.org will be the best place for them (you can ping me @daleharvey)
Cheers
Assignee | ||
Comment 3•5 years ago
|
||
I'm quite new to this so could you please guide me on how to do it? Thanks
Assignee | ||
Comment 4•5 years ago
|
||
Comment 5•5 years ago
|
||
We don't use Bugzilla for development anymore. Please follow the tutorial here :
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Reporter | ||
Comment 6•5 years ago
|
||
Yup as Sylvestre said, specifically the part about submitting a patch (this doesnt really need tested)
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch
Looking at your patch looks good, but if you could remove one of the extra line spaces from either above or below you removed the lines then we wont have 2 new lines
Thank you
Assignee | ||
Comment 7•5 years ago
|
||
Updated•5 years ago
|
Comment 9•5 years ago
|
||
bugherder |
Reporter | ||
Updated•5 years ago
|
Description
•