Closed Bug 1653431 Opened 1 year ago Closed 1 year ago

Remove unused "geo.provider-country.network.scan" pref

Categories

(Core :: DOM: Geolocation, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: daleharvey, Assigned: elainen98, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

https://searchfox.org/mozilla-central/source/dom/system/NetworkGeolocationProvider.jsm#273

This was from before we moved the region fetching into Region.jsm

Hello, can I contribute to this?

Hi Elaine

Sure you can, I have assigned it to you. There are instructions @ https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html to get up and running and if you have any questions, #introductions in chat.mozilla.org will be the best place for them (you can ping me @daleharvey)

Cheers

Assignee: nobody → yilingneoh0305

I'm quite new to this so could you please guide me on how to do it? Thanks

Severity: -- → S4
Priority: -- → P5

We don't use Bugzilla for development anymore. Please follow the tutorial here :
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Flags: needinfo?(dharvey)

Yup as Sylvestre said, specifically the part about submitting a patch (this doesnt really need tested)

https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch

Looking at your patch looks good, but if you could remove one of the extra line spaces from either above or below you removed the lines then we wont have 2 new lines

Thank you

Flags: needinfo?(yilingneoh0305)
Attachment #9164546 - Attachment description: Bug 1653431 - Remove unused _wifiScanningEnabledCountry pref from NetworkGeolocationProvider.jsm. r?daleharvey → Bug 1653431 - Remove unused _wifiScanningEnabledCountry pref. r?daleharvey
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c1c0e744504
Remove unused _wifiScanningEnabledCountry pref. r=daleharvey
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Flags: needinfo?(yilingneoh0305)
You need to log in before you can comment on or make changes to this bug.