1653431 - Remove unused "geo.provider-country.network.scan" pref

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, enhancement, P5)

Description

[Dale Harvey (:daleharvey)]

https://searchfox.org/mozilla-central/source/dom/system/NetworkGeolocationProvider.jsm#273

This was from before we moved the region fetching into Region.jsm

Comment 1

[Elaine Neoh (:elainen98)]

Hello, can I contribute to this?

Comment 2

[Dale Harvey (:daleharvey)]

Hi Elaine

Sure you can, I have assigned it to you. There are instructions @ https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html to get up and running and if you have any questions, #introductions in chat.mozilla.org will be the best place for them (you can ping me @daleharvey)

Cheers

Comment 3

[Elaine Neoh (:elainen98)]

I'm quite new to this so could you please guide me on how to do it? Thanks

Comment 4

[Elaine Neoh (:elainen98)]

Attachment: Removal of unused "geo.provider-country.network.scan" pref

Comment 5

[Sylvestre Ledru [:Sylvestre]]

We don't use Bugzilla for development anymore. Please follow the tutorial here :
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Comment 6

[Dale Harvey (:daleharvey)]

Yup as Sylvestre said, specifically the part about submitting a patch (this doesnt really need tested)

https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch

Looking at your patch looks good, but if you could remove one of the extra line spaces from either above or below you removed the lines then we wont have 2 new lines

Thank you

Comment 7

[Elaine Neoh (:elainen98)]

Attachment: Bug 1653431 - Remove unused _wifiScanningEnabledCountry pref. r?daleharvey

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c1c0e744504
Remove unused _wifiScanningEnabledCountry pref. r=daleharvey

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3c1c0e744504