1653432 - Lockwise Support missing link

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Alexandre Vicenzi]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

Visit about:logins

Actual results:

If there are no credentials there's this message:

Visit Lockwise Support for more help

Lockwise Support is a link, but has no href set to it, if you click nothing happens.

HTML code has no href as below:

<li data-l10n-id="about-logins-intro-instruction-help">Visit <a data-l10n-name="help-link" class="intro-help-link" target="_blank" rel="noreferrer">Lockwise Support</a> for more help</li>

Expected results:

Lockwise Support should have a valid link and open a new tab to the correct page

I can reproduce on Nightly 80.0a1 (2020-07-16) (64-bit) as well Firefox Stable and Developer Edition.

Comment 1

[Alexandre Vicenzi]

The Help button in the menu takes me to https://support.mozilla.org/en-US/products/firefox-lockwise?as=u&utm_source=inproduct, this should probably be the URL in the link.

Comment 2

[Matthew N. [:MattN]]

Hi, thanks for the report. Can you see when this regression started by using mozregression.

Comment 3

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Using mozregression tools I have managed to find which bug introduced this issue. Here are the results:

Last good revision: f9f7b5b1e6ec897fc1009fc5278fe7a650d57018
First bad revision: 13a7265ed7316f2e97300128cb17b02151cf4d43
Pushlog: Link

From this pushlog looks like Bug 1592467 introduced the issue.

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1653432 - Don't wait on AboutLoginsUtilsReady to populate the SUMO URL. r=severin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca50830f9eda
Don't wait on AboutLoginsUtilsReady to populate the SUMO URL. r=severin

Comment 6

[Matthew N. [:MattN]]

Thank you for the report btw!

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ca50830f9eda

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 80.0a1 build (Build ID: 20200724093206). Tested on Windows 10 x64, Mac 10.14.6, and Ubuntu 18.06 x64.

• The "Lockwise Support" link works as expected and opens the Firefox Lockwise Support page in a new tab.
• Also verified that the other links from the logins screen are working as expected.