Closed Bug 1653464 Opened 4 years ago Closed 4 years ago

Add support for detecting XWayland and other desktop environments

Categories

(Core :: Graphics, defect)

Desktop
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

Details

Attachments

(1 file)

We are sometimes detecting the desktop environment wrong (e.g. DWM, Budgie) as well as not making a distinction between X11 and XWayland. We need to fix these to ensure we ship the MVP where we expect to.

I should also note, that we may need to live with (or go through extreme measures to detect) users who manually change XDG_CURRENT_DESKTOP to be GNOME/etc, despite running another desktop environment. They do this to work around applications that should work with e.g. i3, but disable functionality based on the environment variable. It is hard to get a sense of how many users do this.

Type: task → defect

This patch adds detection for XWayland, as that is sometimes an
important distinction when debugging WebRender bugs. For all intents and
purposes, it should work the same as X11, but sometimes does not.

This patch also fixes the desktop environment detection for a few corner
cases. Budgie, in particular, claims to be a GNOME variant, which is not
correct for our purposes, and DWM wasn't detected at all.

FWIW, https://gitlab.freedesktop.org/xorg/app/xisxwayland checks for the RandR output names starting with XWAYLAND.

Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4edf7c080da
Improve Linux desktop and window protocol detection. r=nical
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: