1653520 - Move the getter / setter for compatibility browser list prefs to CompatibilityActor

Status: RESOLVED FIXED

(DevTools :: Inspector: Compatibility, enhancement, P3)

Description

[Kriyszig]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Expected results:

We have code duplication for getting and setting browser list pref in compatibility/UserSetting.js and the CompatibilityActor.
We should move the functions from UserSetting.js to the CompatibilityActor

Comment 1

[Kriyszig]

Attachment: Bug 1653520 - Move the getter and setters from USerSettings into the Compatibility Actor r=daisuke,mtigley

There is a lot of code common between the Compatibility Actor and
the UserSettings and moving this to shared folder will cause
inconsistencies between values read by the client and server.
This patch moves the functions of UserSetting to Compatibility
Actor.

Comment 2

[Kriyszig]

Attachment: Bug 1653520 - Remove code replication in the compatibility actor by moving UserSettings to shared folder r=daisuke,mtigley

Instead of replicationg the browser list fetch using the
preference on the server side, we send the browser list from the
client side to the CompatibilityActor to get the declaration block
compatibility issues.
This way the pref setting is retained completely on the client
side and server doesn't have code duplication.

Depends on D86523

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1bcb0dd0820
Remove code replication in the compatibility actor by moving UserSettings to shared folder r=daisuke,mtigley,devtools-backward-compat-reviewers

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c1bcb0dd0820