1653561 - uriModified = mLoadingEntry->GetURIWasModified(); crashes because of null mLoadingEntry

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

This is a recent regression.

Happens only when session-history-in-parent is enabled.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1648040

Comment 2

[Peter Van der Beken [:peterv]]

Do you have a specific testcase?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Hmm, I was just browsing something. I think it was some case where the page had iframes.

Comment 5

[Julien Cristau [:jcristau]]

fission.sessionHistoryInParent is disabled.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

I think this is still an issue
https://searchfox.org/mozilla-central/rev/5efefd3ef214ed6d3234ba245c1da3004ead94e0/docshell/base/nsDocShell.cpp#9982

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1653561, Get URIWasModified from mLoadingEntry when it is available, r=peterv

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e34c173ed83c
Get URIWasModified from mLoadingEntry when it is available, r=peterv

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e34c173ed83c