1653577 - Add some NS_ASSERTIONs for unexpected failures in directwrite font code

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement)

Description

[Jonathan Kew [:jfkthame]]

There are several places in gfxDWriteFontList::MakePlatformFont, the method that instantiates a platform font reference from downloaded webfont data, that could in theory fail, and we just silently return.

To help diagnose any case where we're actually encountering such failures (which could account for reftest flakiness on Win7, for example, if directwrite sometimes fails to accept the downloaded font), I'd like to add (non-fatal) NS_ASSERTION messages so that logs will clearly show where things went wrong.

(I have no firm evidence that we're ever actually experiencing any of these failure cases in the CI test suites, in which case the assertions will simply never fire; but if it does happen we really ought to know about it.)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1653577 - Add NS_ASSERTION to various failure cases in gfxDWriteFontList::MakePlatformFont, rather than just silently failing. r=lsalzman

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3030fc89d01e
Add NS_ASSERTION to various failure cases in gfxDWriteFontList::MakePlatformFont, rather than just silently failing. r=lsalzman

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3030fc89d01e