Rename MasterPassword policy to PrimaryPassword policy
Categories
(Firefox :: Enterprise Policies, enhancement)
Tracking
()
People
(Reporter: mkaply, Assigned: mkaply)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-esr78+
|
Details | Review |
Firefox 79 is our first release with the new MasterPassword policy.
Once we've released a policy with a given name, we have to keep it forever. We can deprecate it, but it still has to stay in the docs.
I'd like to get the main policy name renamed to PrimaryPassword now before we ship it so we don't have to worry about it.
I'm not changing any implementation, just policy name for now so it will be a minimal patch.
Assignee | ||
Comment 1•8 months ago
|
||
This affects ESR as well.
Assignee | ||
Comment 2•8 months ago
|
||
[Tracking Requested - why for this release]: Once a policy is released, it sticks around forever for legacy. Since this policy is new for 79, if we get it renamed before we ship, we don't have to rename (or change docs).
Updated•8 months ago
|
Assignee | ||
Comment 3•8 months ago
|
||
Updated•8 months ago
|
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/7bcb681545cb Rename MasterPassword policy to PrimaryPassword. r=Gijs
Comment 5•8 months ago
|
||
Backed out for failures on test_sorted_alphabetically.js
backout: https://hg.mozilla.org/integration/autoland/rev/4da55bb2189c19a81d4c25facee4ca2c8be3eda9
failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310178608&repo=autoland&lineNumber=6798
[task 2020-07-17T15:26:08.300Z] 15:26:08 INFO - TEST-START | browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js
[task 2020-07-17T15:26:08.680Z] 15:26:08 WARNING - TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js | xpcshell return code: 0
[task 2020-07-17T15:26:08.681Z] 15:26:08 INFO - TEST-INFO took 380ms
[task 2020-07-17T15:26:08.681Z] 15:26:08 INFO - >>>>>>>
[task 2020-07-17T15:26:08.681Z] 15:26:08 INFO - PID 1076 | [1076, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 121
[task 2020-07-17T15:26:08.682Z] 15:26:08 INFO - PID 1076 | [1076, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 121
[task 2020-07-17T15:26:08.682Z] 15:26:08 INFO - PID 1076 | [1076, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 121
[task 2020-07-17T15:26:08.682Z] 15:26:08 INFO - PID 1076 | [1076, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 121
[task 2020-07-17T15:26:08.683Z] 15:26:08 INFO - PID 1076 | [1076, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 121
[task 2020-07-17T15:26:08.683Z] 15:26:08 INFO - PID 1076 | [1076, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp, line 2914
[task 2020-07-17T15:26:08.684Z] 15:26:08 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-07-17T15:26:08.684Z] 15:26:08 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2020-07-17T15:26:08.684Z] 15:26:08 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2020-07-17T15:26:08.685Z] 15:26:08 INFO - running event loop
[task 2020-07-17T15:26:08.685Z] 15:26:08 INFO - browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js | Starting test_policies_sorted
[task 2020-07-17T15:26:08.685Z] 15:26:08 INFO - (xpcshell/head.js) | test test_policies_sorted pending (2)
[task 2020-07-17T15:26:08.686Z] 15:26:08 WARNING - TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js | test_policies_sorted - [test_policies_sorted : 18] policies-schema.json is alphabetically sorted. - false == true
[task 2020-07-17T15:26:08.686Z] 15:26:08 INFO - Z:/task_1594997737/build/tests/xpcshell/tests/browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js:checkArrayIsSorted:18
[task 2020-07-17T15:26:08.686Z] 15:26:08 INFO - Z:/task_1594997737/build/tests/xpcshell/tests/browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js:test_policies_sorted:29
[task 2020-07-17T15:26:08.686Z] 15:26:08 INFO - Z:\task_1594997737\build\tests\xpcshell\head.js:_run_next_test/<:1618
[task 2020-07-17T15:26:08.686Z] 15:26:08 INFO - Z:\task_1594997737\build\tests\xpcshell\head.js:_run_next_test:1618
[task 2020-07-17T15:26:08.686Z] 15:26:08 INFO - Z:\task_1594997737\build\tests\xpcshell\head.js:run:777
[task 2020-07-17T15:26:08.686Z] 15:26:08 INFO - Z:\task_1594997737\build\tests\xpcshell\head.js:_do_main:248
[task 2020-07-17T15:26:08.687Z] 15:26:08 INFO - Z:\task_1594997737\build\tests\xpcshell\head.js:_execute_test:577
[task 2020-07-17T15:26:08.687Z] 15:26:08 INFO - -e:null:1
Assignee | ||
Comment 6•8 months ago
|
||
Repushed this time in alphabetical order.
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/34515f632088 Rename MasterPassword policy to PrimaryPassword. r=Gijs
Comment 8•8 months ago
|
||
bugherder |
Assignee | ||
Comment 9•8 months ago
|
||
Comment on attachment 9164348 [details]
Bug 1653584 - Rename MasterPassword policy to PrimaryPassword. r?Gijs
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only, want to get rename in before policy is first released.
- User impact if declined: We'll have to deprecate the old policy and keep it around.
- Fix Landed on Version: 80
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): automated test, just a rename
- String or UUID changes made by this patch:
Beta/Release Uplift Approval Request
- User impact if declined: We'll have to deprecate the old policy and keep it around.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): automated test, just a rename
- String changes made/needed:
Comment 10•8 months ago
|
||
Comment on attachment 9164348 [details]
Bug 1653584 - Rename MasterPassword policy to PrimaryPassword. r?Gijs
Approved for 79.0rc1 and 78.1esr.
Comment 11•8 months ago
|
||
bugherderuplift |
Comment 12•8 months ago
|
||
bugherderuplift |
Updated•8 months ago
|
Updated•8 months ago
|
Comment 13•8 months ago
•
|
||
I verified the bug using the latest Nightly 80.0a1 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.15. MasterPassword is changed to PrimaryPassword in about:preferences#privacy.
On the other hand on Firefox 79.0 the title still remains Master Password. Or should have I verified the issue some other way?
Assignee | ||
Comment 14•8 months ago
|
||
On the other hand on Firefox 79.0 the title still remains Master Password. Or should have I verified the issue some other way?
It was just uplifted to the RC, so it will be in today's build. See comment 11.
Comment 15•8 months ago
•
|
||
Verified this using: Firefox 80.0a1 (BuildId:20200721094241), Firefox 79.0 (BuildId:20200720193547) and Firefox 78.1.0esr (provided in comment 12) on Windows 10 64bit, macOS 10.14 and Ubuntu 18.04 64bit.
The MasterPassword
key was renamed to PrimaryPassword
and the original policy functionality remains intact.
Tested using a policies.json file with the policy on both true and false values.
On true
- The Primary Password creation is enabled.
- Once created, the password cannot be removed.
On false
- The Primary Password creation is disabled.
Description
•