Closed Bug 1653594 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24646 - Apply |PostLayout| to |LayoutBox| instead of |LayoutBlockFlow|

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24646 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24646
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

Apply |PostLayout| to |LayoutBox| instead of |LayoutBlockFlow|

|PostLayout| was limited to |LayoutBlockFlow| because
crbug.com/965639 could happen only to|LayoutBlockFlow|,
but following conditions have changed:

  • Only |LayoutBlockFlow| could be relayout boundary, until
    r772560 \<crrev.com/c/2219312>.
  • Only |LayoutBlockFlow| was laid out by LayoutNG, until
    |LayoutNGFlexibleBox| inherits from |LayoutBlock|.

This patch changes |PostLayout| to work for |LayoutBox|.

In doing so, two changes were made:

  1. |CurrentFragment| is replaced with |GetPhysicalFragment|
    because the former is not available for |LayoutBox|.
  2. Stopped checking |IsRelayoutBoundary|. Though it is the
    only case crbug.com/965639 can happen as far as we're
    aware of, checking |NGPhysicalFragment| is more
    essential and sufficient.

The change 1 also helps \<crbug.com/1061423>, but we may need
different approach to support block fragmentation.

Bug: 1102151, 965639
Change-Id: Id83be614066392a4c58c8b03bd16ee57ad82e145

Reviewed-on: https://chromium-review.googlesource.com/2302984
WPT-Export-Revision: 1092f4cae1954bf70bd1f0422537e8a41129afa2

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e68a21534501
[wpt PR 24646] - Apply |PostLayout| to |LayoutBox| instead of |LayoutBlockFlow|, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e68a21534501

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.