1653728 - [wpt-sync] Sync PR 24653 - [css-flexbox] Don't always reuse cached layout for row flex containers

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24653 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24653
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

[css-flexbox] Don't always reuse cached layout for row flex containers

CalculateSizeBasedLayoutCacheStatusWithGeometry checks if the cached
layout information can be reused. The problem was that, if a flex
container had a percentage height, and the size of its containing block
changed, a new layout would only be performed in case it was a column
flex container. For row flex containers, the cached layout would be
reused.

However, row containers may also need a new layout in some cases.
This patch removes the check for column flex containers, so that row
ones can be included too.

Bug: 1103592

TEST=external/wpt/css/css-flexbox/height-percentage-with-dynamic-container-size.html

Change-Id: Ib2c119febdfa56b31f5524be3df85c9749dd1f6a
Reviewed-on: https://chromium-review.googlesource.com/2302997
WPT-Export-Revision: c6be2f6e8933c2444f6b9b7a81a610f9d77d88d8

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9065ec7467902818ac18d2538c8d631c8bc452e8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PASS: 3

Chrome

OK : 1
FAIL: 3

Safari

OK : 1
PASS: 3

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/241c66e9bec4
[wpt PR 24653] - [css-flexbox] Don't always reuse cached layout for row flex containers, a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/241c66e9bec4