Closed Bug 1653729 Opened 5 years ago Closed 5 years ago

Generalize do_QueryActor APIs with support for JSProcessActor

Categories

(Core :: DOM: Content Processes, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
81 Branch
Fission Milestone M7
Tracking Status
firefox81 --- fixed

People

(Reporter: nika, Assigned: nika)

Details

Attachments

(3 files)

No description provided.

This changes the set of types which can be passed as the second argument to
do_QueryActor to ones which can be unambiguously converted to a JSActorManager,
and combines nsCOMPtr_helper implementations.

Before this change, nsIDOMProcess{Parent,Child} could not directly be used in
do_QueryActor, as they don't directly inherit from JSActorManager.

The std::enable_if_t trickery is required in order to avoid overload issues when
passing types like ContentChild which inherit from both JSActorManager and
nsIDOMProcess{Parent,Child}.

This should make it easier to get an XPCOM interface from a JSProcessActorChild
in the current process, when combined with the do_QueryActor overloads from p2.

Status: NEW → ASSIGNED
Fission Milestone: --- → M7
Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9db5db7c2b0e Part 1: Generalize do_QueryActor API, r=kmag https://hg.mozilla.org/integration/autoland/rev/6169f483a5ca Part 2: Add methods for do_QueryActor from nsIDOMProcess*, r=kmag https://hg.mozilla.org/integration/autoland/rev/ef6b1b08c555 Part 3: Add nsIDOMProcessChild::GetSingleton helper, r=kmag
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: