1653762 - [wpt-sync] Sync PR 24657 - Python 3: Drop use of flush on ResponseWriter in a couple of files

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24657 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24657
Details from upstream follow.

Ziran Sun <[e-mail]> wrote:

Python 3: Drop use of flush on ResponseWriter in a couple of files

This patch only drops the use of response.write.flush() in a couple of
files as they directly affect test results in Python 3.

Detailed discussions on dropping use of flush on ResponseWriter can be
found at https://github.com/web-platform-tests/wpt/pull/24617

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=af00b67a47a8335a45c5e0070096e8d1c4435066

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests and 1 subtests

Status Summary

Firefox

OK : 6[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] 7[GitHub]
PASS : 11
FAIL : 4[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] 5[GitHub]
TIMEOUT: 2

Chrome

OK : 7
PASS : 15
FAIL : 1

Safari

OK : 5
PASS : 14
ERROR : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/fetch/range/general.any.html
Fetch with range header will be sent with Accept-Encoding: identity: FAIL
/fetch/range/general.any.worker.html
Fetch with range header will be sent with Accept-Encoding: identity: FAIL

New Tests That Don't Pass

/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_allow_downloads.sub.tentative.html: OK [GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: OK, Safari: OK)
Navigation resulted download in sandbox is allowed by allow-downloads.: PASS [GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: PASS, Safari: PASS)
/fetch/range/general.any.html
Fetch with range header will be sent with Accept-Encoding: identity: FAIL (Chrome: PASS, Safari: PASS)
/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_block_downloads.sub.tentative.html
<a download> triggered download in sandbox is blocked.: FAIL (Chrome: PASS)
/fetch/range/general.any.worker.html
Fetch with range header will be sent with Accept-Encoding: identity: FAIL (Chrome: PASS, Safari: PASS)
/fetch/range/general.window.html
Fetch with range header will be sent with Accept-Encoding: identity: FAIL (Chrome: FAIL, Safari: PASS)
/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_block_downloads.sub.tentative.html
Navigation resulted download in sandbox is blocked.: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35b027b01080
[wpt PR 24657] - Python 3: Drop use of flush on ResponseWriter in a couple of files, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b639ad5c556f
[wpt PR 24657] - Update wpt metadata, a=testonly

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/35b027b01080
https://hg.mozilla.org/mozilla-central/rev/b639ad5c556f