Closed Bug 1653897 Opened 4 years ago Closed 4 years ago

Fix the C# sample app to report the correct version on Windows 10

Categories

(Data Platform and Tools :: Glean: SDK, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: daoshengmu, Assigned: daoshengmu)

Details

(Whiteboard: [telemetry:glean-rs:m18])

Attachments

(1 file)

Please run C# sample and check its pings in Glean Ping Debug Viewer. We can see its pings include a wrong Windows version, "6.2.9200.0" (I am using Windows 10). However, if I run Glean Unity, it shows a correct Windows version no. at its pings.

It looks like we should use OperatingSystemVersion instead of OperatingSystem [2].

[1] Windows OS version, https://docs.microsoft.com/en-us/windows/win32/sysinfo/operating-system-version?redirectedfrom=MSDN
[2] Fix OS Version in Summary for Windows 10, https://github.com/dotnet/BenchmarkDotNet/issues/351

This is not a bug in Glean per se, but we should probably do what we recommend doing in the C# sample app (= fix the manifest).

Priority: -- → P3
Summary: Glean C# binding submits pings with wrong Windows version → Fix the C# sample app to report the correct version on Windows 10
Whiteboard: [telemetry:glean-rs:m?]
Whiteboard: [telemetry:glean-rs:m?] → [telemetry:glean-rs:m18]
Attached file GitHub Pull Request
Assignee: nobody → alessio.placitelli
Assignee: alessio.placitelli → dmu
Priority: P3 → P1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: