Closed Bug 1653914 Opened 2 months ago Closed 2 months ago

Add profiler sub-categories for the GC

Categories

(Core :: JavaScript: GC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: jonco, Assigned: allstars.chh)

Details

Attachments

(2 files)

As suggested by Ted we can add profiler subcategories for different parts of the GC.

At a minimum we should have categories for major GC, minor GC, gray unmarking and barriers. Possibly we could have subcategories for the major phases of major GC too (e.g. mark, sweep, compact, etc).

This happened for the JITs in bug 1645469.

Yoshi, do you think you could take a look at this?

Flags: needinfo?(allstars.chh)
Assignee: nobody → allstars.chh
Flags: needinfo?(allstars.chh)

(In reply to Jon Coppeard (:jonco) from comment #0)

At a minimum we should have categories for major GC, minor GC, gray unmarking and barriers.
For barriers, is it different from unmarking gray?
for example in https://searchfox.org/mozilla-central/rev/cffd9b5302b6b6f51533d895a785b48ff418aec1/js/src/gc/Marking.cpp#4284
The AutoPhase BARRIER is the same as UNMARK_GRAY.

(In reply to Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh] from comment #2)

For barriers, is it different from unmarking gray?

Yes, see js::gc::PerformIncrementalReadBarrier and the IncrementalPreWriteBarrier methods.

Pushed by allstars.chh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9e643c3998d5
Add profiler GC subcategories. r=jonco
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.