1653914 - Add profiler sub-categories for the GC

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Jon Coppeard (:jonco)]

As suggested by Ted we can add profiler subcategories for different parts of the GC.

At a minimum we should have categories for major GC, minor GC, gray unmarking and barriers. Possibly we could have subcategories for the major phases of major GC too (e.g. mark, sweep, compact, etc).

This happened for the JITs in bug 1645469.

Comment 1

[Jon Coppeard (:jonco)]

Yoshi, do you think you could take a look at this?

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Jon Coppeard (:jonco) from comment #0)

At a minimum we should have categories for major GC, minor GC, gray unmarking and barriers.
For barriers, is it different from unmarking gray?
for example in https://searchfox.org/mozilla-central/rev/cffd9b5302b6b6f51533d895a785b48ff418aec1/js/src/gc/Marking.cpp#4284
The AutoPhase BARRIER is the same as UNMARK_GRAY.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1653914 - Add profiler GC subcategories.

Comment 4

[Jon Coppeard (:jonco)]

(In reply to Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh] from comment #2)

For barriers, is it different from unmarking gray?

Yes, see js::gc::PerformIncrementalReadBarrier and the IncrementalPreWriteBarrier methods.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e643c3998d5
Add profiler GC subcategories. r=jonco

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9e643c3998d5

Comment 7

[Jon Coppeard (:jonco)]

Attachment: Looks like this is working nicely.