1653943 - browser_TroubleShoot.js asserts that all feature gated experiments are disabled by default but this isn't the case

Status: RESOLVED FIXED

(Firefox :: Settings UI, task, P3)

Description

[:Gijs (out for now; he/him)]

Right now we "just" add prefs that are default-enabled on nightly as pushPrefEnv entries so that the test doesn't fail, but that's an annoying non-solution.

Can we just stop asserting this expectation, or is there meant to be a guarantee that we're just breaking all over the place, or should we be replacing this assumption with something else (cf. discussion in https://phabricator.services.mozilla.com/D81624 ).

:mythmon, can you comment on what you think we should do here? I can sort of guess based on your comment in D81624 but it seems better to actually make sure we're all on the same page here. :-)

Comment 1

[Michael Cooper [:mythmon]]

I'm failing to see a solid connection between this as D81624, but I agree that we shouldn't assert that feature gates are disabled by default. The system allows you to express that a feature is on by default without removing the feature gate, and having a test that removes the functionality doesn't make sense to me.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1653943 - Remove unnecessary test assertion that complicates production code. r?jaws

Asserting that features with gates are always disabled seems unnecessary,
and forces changes to the test every time a feature is enabled by default.

Depends on D85432

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad5909461c4a
Remove unnecessary test assertion that complicates production code. r=jaws

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ad5909461c4a