1653950 - Bump glib version requirement

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Robert Mader [:rmader]]

We still support glib versions not having this - so silence a bunch of warnings by replacing it with slightly longer code.

Comment 1

[Robert Mader [:rmader]]

Attachment: Bug 1653950 - Replace g_clear_pointer with backward compatible version, r=stransky

We still support glib versions not having this - so silence a bunch of
warnings by replacing it with slightly longer code.

Comment 2

[Karl Tomlinson (:karlt)]

The upgrade of build machines to Debian 8, I assume means the build is now against libglib2.0-0 2.42.1-1+deb8u3.

GTK version for build has increased and systems with GTK 3.14 need at least GLib 2.41.2, so it's appropriate to increase GLIB_VERSION_MIN_REQUIRED to GLIB_VERSION_2_42.

g_clear_pointer() is available from version 2.34.

Comment 3

[Robert Mader [:rmader]]

Attachment: Bug 1653950 - Bump glib version requirement. r=karlt

We already inherit a minimum version of 2.41.2 through GTK 3.14.
This silences some build warnings.

Comment 4

[Robert Mader [:rmader]]

Karl, I suppose we need to make sure this gets updated in docs etc.?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5df50fa24cca
Bump glib version requirement. r=karlt

Comment 6

[Karl Tomlinson (:karlt)]

Ryan, system requirements for GTK were updated in https://bugzilla.mozilla.org/show_bug.cgi?id=1634204#c22.
The GLib build requirement update here is already implicit in that (2.41 is the pre-release versioning for the 2.42 release), but the GLib 22.2 requirement on https://www.mozilla.org/en-US/firefox/78.0.2/system-requirements/ is therefore unnecessary.

Similarly, Pango 1.22 is very old and GTK 3.14 requires Pango 1.36.7, so the Pango requirement also need not be specified.

Are you the best person to contact re getting the Pango and GTK requirements removed from future system-requirements pages?

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on gversionmacros.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/8cfbd5213d0487638348ed32cf92d6b701e6dc99
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310779225&repo=autoland&lineNumber=6052

Comment 8

[Robert Mader [:rmader]]

Meh, updated.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0650d1a61f16
Bump glib version requirement. r=karlt

Comment 10

[Atila Butkovits]

Backed out for bustages on gversionmacros.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/de6e53cc788967b7082d0abc4dbe41b1fb9ea6c8

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=e2urKqeaSr2WH89ZVVey2g.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=0650d1a61f169558c9f63219a57bd50ef7984936

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310791727&repo=autoland&lineNumber=5013

Comment 11

[Ryan VanderMeulen [:RyanVM]]

(In reply to Karl Tomlinson (:karlt) from comment #6)

the GLib 22.2 requirement [...] is therefore unnecessary.
the Pango requirement also need not be specified.

I've removed both from the Fx78+ system requirements. Should show up on the live site in the next 15-20min.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d6b7dda1e6b
Bump glib version requirement. r=karlt

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3d6b7dda1e6b