1653956 - Link errors in Debugger.cpp in non-unified, optimised builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[André Bargull [:anba]]

Building non-unified with optimisations enabled gives link errors:

/tmp/lto-llvm-09f373.o: In function `js::DebugAPI::slowPathOnLeaveFrame(JSContext*, js::AbstractFramePtr, unsigned char*, bool)':
/home/andre/hg/mozilla-inbound/js/src/debugger/Debugger.cpp:1114: Undefined reference to `js::DebuggerFrame::owner() const'
/tmp/lto-llvm-09f373.o: In function `js::DebugAPI::onSingleStep(JSContext*)':
/home/andre/hg/mozilla-inbound/js/src/debugger/Debugger.cpp:2640: Undefined reference to `js::DebuggerFrame::owner() const'
/tmp/lto-llvm-09f373.o: In function `js::Debugger::replaceFrameGuts(JSContext*, js::AbstractFramePtr, js::AbstractFramePtr, js::ScriptFrameIter&)':
/home/andre/hg/mozilla-inbound/js/src/debugger/Debugger.cpp:6367: Undefined reference to `js::DebuggerFrame::owner() const'
/usr/bin/ld: libmozjs-80a1.so: hidden symbol `_ZNK2js13DebuggerFrame5ownerEv' isn't defined

js::DebuggerFrame::owner is defined as inline in "js/src/debugger/Frame.cpp", but used outside of that cpp file.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1653956: Remove `inline` specifier for functions defined in cpp file. r=loganfsmyth!

This avoids undefined reference errors for "js::DebuggerFrame::owner()" when
building non-unified with optimisations enabled.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32e624667516
Remove `inline` specifier for functions defined in cpp file. r=loganfsmyth

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/32e624667516