Closed Bug 1654016 Opened 2 months ago Closed 2 months ago

FinalizationQueueObject::create doesn't check whether GetObjectFromIncumbentGlobal gave us a null pointer

Categories

(Core :: JavaScript: GC, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

As pointed out by anba, js::GetObjectFromIncumbentGlobal has a boolean return value but it can also set its out parameter to nullptr on success. FinalizationQueueObject::create should check for this.

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72ec4b8c3a56
Check whether js::GetObjectFromIncumbentGlobal returns null r=sfink
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.