Closed
Bug 1654016
Opened 6 years ago
Closed 6 years ago
FinalizationQueueObject::create doesn't check whether GetObjectFromIncumbentGlobal gave us a null pointer
Categories
(Core :: JavaScript: GC, defect, P1)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
As pointed out by anba, js::GetObjectFromIncumbentGlobal has a boolean return value but it can also set its out parameter to nullptr on success. FinalizationQueueObject::create should check for this.
|
Assignee | |
Comment 1•6 years ago
|
||
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72ec4b8c3a56
Check whether js::GetObjectFromIncumbentGlobal returns null r=sfink
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in
before you can comment on or make changes to this bug.
Description
•