1654029 - When only the search box is enabled in Firefox newtab, the Firefox logo is no longer displayed

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Tim Spurway [:tspurway]]

Attachment: image.png

STR:

• in a new profile (I have tested this in 78, 79, and 80, macOS) go to the preferences for newtab
• disable all sections except Search
• open a new tab

Expected:
A Firefox logo above the search bar

Found:
No logo

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1654029 - Fix newtab firefox logo for search only

Comment 2

[Scott [:thecount] Downe]

Regressed in https://bugzilla.mozilla.org/show_bug.cgi?id=1649883

What happened.

When we split the topstories pref into a user pref and a system pref, I initially had the system pref also return the state of the user pref. This had a bug, so the fix was to keep both prefs separate and check them in all cases, that's what the above regression bug fixed.

We missed a spot though where both values were not checked. This is because that check didn't directly check the pref value, but instead checked the enabled value of the feed, which is set via the system pref. This created a situation where the user pref was being ignored, and the pocket status was still "enabled". We actually want to check both system and user pref, and ignore the feed state for topstories.

My fix is to filter out the topstories entry in feeds, and then check for both topstories prefs, if either of them are not enabled, we consider pocket off.

To test:

1. Go to about:preferences#home
2. Disable everything ceptsearch
3. open a newtab

Expected: You should see a search input and a firefox logo.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64ca4842a6c7
Fix newtab firefox logo for search only r=gvn

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/64ca4842a6c7

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (80.0a1 Build ID - 20200722215545) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15. Now, the Firefox logo is successfully displayed on the New Tab page after all the sections except the in-content search bar are dismissed.