1654042 - [Mac] Empty menuitem in File menu

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Stefan [:stefanh]]

On Mac, the "menu_printPreview" menuitem shows up empty in the file menu. It shouldn't be there at all. My guess is that it shows up because it exists in various files, but only non-mac will get a label (and other stuff, like a command) from utilityOverlay.xul (the old platformoverlay that was removed had <menuitem id="menu_printPreview" hidden="true"/>)

Side note: I should have noticed this earlier...

Comment 1

[Stefan [:stefanh]]

Attachment: empty_menuitem.png

Comment 2

[Ian Neal]

Attachment: Hide printPreview in File menu

[Approval Request Comment]
Regression caused by (bug #): 1611714
User impact if declined: Blank line in File menu on mac
Testing completed (on m-c, etc.): 2.53.4
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 3

[Stefan [:stefanh]]

Comment on attachment 9165453 [details] [diff] [review]
Hide printPreview in File menu

Thanks. r=me (code inspection only).

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9165453 [details] [diff] [review]
Hide printPreview in File menu

LGTM

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c666f225f822
[Mac] Empty menuitem in File menu. f=stefanh

Comment 6

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/36d292f417c177378dc2eeb3146b714c448badc8
[Mac] Empty menuitem in File menu. r=stefanh a=frg
Target 2.53.4