1654100 - Measure the elapsed time of ShellExecuteByExplorer

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement, P3)

Description

[Toshihito Kikuchi [:toshi]]

Bug 1646986 told us ShellExecuteByExplorer could block the thread under some unknown circumstances. It would be good to collect data of the elapsed time of that API to see how common such a situation is.

Comment 1

[Toshihito Kikuchi [:toshi]]

Attachment: data-review-request-for-bug1654100.txt

Comment 2

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1654100 - Measure the elapsed time of ShellExecuteByExplorer. r=gijs

This patch adds a new measurement to the histogram about the elapsed time
of ShellExecuteByExplorer. If ShellExecuteByExplorer takes long in
a considerable number of instances, we need to consider fixing bug 1646986.

Comment 3

[Chris H-C :chutten]

Comment on attachment 9165160 [details]
data-review-request-for-bug1654100.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :toshi is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e556d9c0845
Measure the elapsed time of ShellExecuteByExplorer.  r=froydnj

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6e556d9c0845

Comment 6

[Toshihito Kikuchi [:toshi]]

Attachment: histogram.PNG

Comment 7

[Toshihito Kikuchi [:toshi]]

Attaching the screenshot of the histogram. The duration is distributed without any unexpected peaks. There are instances where the API takes a long time, but the volume is not so high. No immediate action is needed.

Comment 8

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1654100 - Backed out changeset 6e556d9c0845. r=froydnj

Now that we've concluded no immediate action is needed for slow
ShellExecuteByExplorer, SHELLEXECUTEBYEXPLORER_DURATION_MS is
no longer needed.

Comment 9

[Toshihito Kikuchi [:toshi]]

Attachment: histogram-beta80.png

Getting data from Beta 80. The trend is the same as Nightly. There is just one peak, without having an additional peak that would be caused by a common factor.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93d8458a0c4d
Backed out changeset 6e556d9c0845.  r=froydnj

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/93d8458a0c4d

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Change the status for beta to have the same as nightly and release.
For more information, please visit auto_nag documentation.