1654106 - Assertions because TimeStamp::IsNull() in ImageComposite::DetectTimeStampJitter

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I've experienced flashes with apparent GPU process crashes when profiling, with this assertion failure:

Assertion failure: !IsNull() (Cannot compute with a null value), at c:/mozilla-source/obj-mc-dbg/dist/include\mozilla/TimeStamp.h:482
#01: mozilla::layers::ImageComposite::SetImages (c:\mozilla-source\mozilla-central\gfx\layers\composite\ImageComposite.cpp:210)
#02: mozilla::layers::WebRenderImageHost::UseTextureHost (c:\mozilla-source\mozilla-central\gfx\layers\wr\WebRenderImageHost.cpp:70)
#03: mozilla::layers::CompositableParentManager::ReceiveCompositableUpdate (c:\mozilla-source\mozilla-central\gfx\layers\ipc\CompositableTransactionParent.cpp:179)
#04: mozilla::layers::CompositableParentManager::ReceiveCompositableUpdate (c:\mozilla-source\mozilla-central\gfx\layers\ipc\CompositableTransactionParent.cpp:70)
#05: mozilla::layers::WebRenderBridgeParent::ProcessWebRenderParentCommands (c:\mozilla-source\mozilla-central\gfx\layers\wr\WebRenderBridgeParent.cpp:1370)
#06: mozilla::layers::WebRenderBridgeParent::ProcessDisplayListData (c:\mozilla-source\mozilla-central\gfx\layers\wr\WebRenderBridgeParent.cpp:1070)
#07: mozilla::layers::WebRenderBridgeParent::RecvSetDisplayList (c:\mozilla-source\mozilla-central\gfx\layers\wr\WebRenderBridgeParent.cpp:1123)
[...]

I'll prepare a quick fix (checking for null timestamps), but I'm not a graphics expert so please take over if it should be done differently.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1654106 - Check that image timestamps are not null before subtracting them - r?mstange,jrmuizel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a3440bf9f3d
Check that image timestamps are not null before subtracting them - r=mstange

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2a3440bf9f3d

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1653350