Rename threads in GMPServiceParent and GMPParent to reflect main thread usage
Categories
(Core :: Audio/Video: GMP, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: bryce, Assigned: bryce)
Details
Attachments
(1 file)
Bug 1648363 removed AbstractThread usage from GMP code. These changes also renamed a couple of member variables from mMainThread to mWorkerThread. The worker thread convention is used to indicate that a generic thread can be used to perform work. I.e. that thread need not be the main thread or some other special thread.
However, for these GMP use cases we do expect many function invocations to be done on the main thread. E.g. GMPServiceParent.cpp has a large number of asserts to ensure functions are called on the main thread. One of the reasons for this is that in both the parent and content process GMP code interacts with services that appear to be main thread only.
I suggest we revert the renaming aspect of bug 1648363 to make it clearer that we do indeed want to use the main thread in various cases.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Comment 2•4 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bryce, could you have a look please?
For more information, please visit auto_nag documentation.
Pushed by bvandyk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/400346c54de1 Rename threads in GMPServiceParent and GMPParent to reflect main thread usage. r=jolin,jya
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Description
•