1654169 - Sync surface of GeckoSurface always uses non single buffer surface

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

SyncSurface of GeckoSurface always uses non single buffer surface. non single buffer surface uses more memory than singe buffer surface.

https://searchfox.org/mozilla-central/rev/9b282b34b5aa0f836beb735656c55efb2cc4c617/mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/GeckoSurface.java#119

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1654169 - Use single buffered mode surface as sync surfacce if possible

Comment 2

[Sotaro Ikeda [:sotaro]]

:jhlin, is there a reason why single buffer mode surface is not used for sync surface?

Comment 3

[John Lin [:jhlin][:jolin]]

(In reply to Sotaro Ikeda [:sotaro] from comment #2)

:jhlin, is there a reason why single buffer mode surface is not used for sync surface?

Not really. Thanks for the help!

Comment 4

[Sotaro Ikeda [:sotaro]]

Sync surface is used only when content process uses GonkSurfaceTexture. The following diagram might help to understand it.

• https://github.com/sotaroikeda/firefox-diagrams/blob/master/mobile/mobile_SurfaceAllocatorService_68.pdf

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/faa4b21ccbf2
Use single buffered mode surface as sync surfacce if possible r=geckoview-reviewers,snorp

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/faa4b21ccbf2