1654323 - Wrong selection color when using the GTK backend

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Corentin Noël]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Select a text on any webpage

Actual results:

The text and background colors haven't changed

Expected results:

The text and background colors should be the selected text color

Comment 1

[Corentin Noël]

I think that I found the issue:
According to https://github.com/mozilla/gecko-dev/blob/master/widget/gtk/nsLookAndFeel.cpp#L1128 it seems that Firefox is using the color of the selected|active state of GtkTextView.text
According to the Gtk documentation ( https://developer.gnome.org/gtk3/stable/GtkTextView.html#id-1.3.11.8.12.3 ) the GtkTextView has a selection node which is the one providing the selection color

Comment 2

[Corentin Noël]

Issue reproducible with the latest elementary OS GTK Stylesheet https://github.com/elementary/stylesheet/

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Is there any simple test case available?
Thanks.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

The colors that we use are these.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Ah, sorry, they were linked already above...

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1654323 - Use GtkTextView.text.selection to get selection colors in GTK.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

The attached patch should fix it, but if you can give a way to repro the issue on Fedora it'd be great, so that I can confirm it. Otherwise could you confirm that before I send it for review? :)

Comment 9

[Corentin Noël]

I'm unable to test it as it seems that running ./mach build on my system doesn't take the changes to the GTK backend into account. To test it, simply use the latest master of the elementary GTK theme ( https://github.com/elementary/stylesheet/ )

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee33d63ab06a
Use GtkTextView.text.selection to get selection colors in GTK. r=stransky

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ee33d63ab06a