Closed Bug 1654350 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24687 - Revert "[COOP] access reporting [5/N] Plumb report type."

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24687 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24687
Details from upstream follow.

Katie Dektar <katie@chromium.org> wrote:

Revert "[COOP] access reporting [5/N] Plumb report type."

This reverts commit 6e52cf215e6406f19c38227899f5cd392998c0e0.

Reason for revert: Speculative revert: A related test has begun
failing since this landed.

Failing test:
external/wpt/html/cross-origin-opener-policy/reporting/access-reporting/property.https.htm

First failing build (with this change in blamelist):
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/16841

Original change's description:

[COOP] access reporting [5/N] Plumb report type.

All of this is put behind a flag disabled by default.
This is mostly based on the initial prototype:
https://chromium-review.googlesource.com/c/chromium/src/+/2223934/24

Define, plumb and use the "report-type" for COOP access reporting.

COOP access reporting:
[1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294
[2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185
[3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472
[4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120
[5/N] this patch.

Bug: chromium:1090273
Change-Id: I5e51b3da6a20c85c073ea1fd84ea74557760a42f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309433
Commit-Queue: Arthur Sonzogni \<arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy \<clamy@chromium.org>
Reviewed-by: Pâris Meuleman \<pmeuleman@chromium.org>
Reviewed-by: Mike West \<mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790420}

TBR=clamy@chromium.org,mkwst@chromium.org,arthursonzogni@chromium.org,pmeuleman@chromium.org

Change-Id: I88a01f1dc601205b2344c4251747cf75ef5a84d0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1090273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310769
Reviewed-by: Katie Dektar \<katie@chromium.org>
Commit-Queue: Katie Dektar \<katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790466}

PR 24687 applied with additional changes from upstream: 9a68a82ca3e679951c20e504cdf26113575f6952, 381ffe1a5688d6689a88d2b39d60497fb032d393
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 38 subtests

Status Summary

Firefox

FAIL : 2[Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt, Gecko-windows7-32-opt, GitHub] 5[Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows7-32-debug]
TIMEOUT: 2
NOTRUN : 32[Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows7-32-debug] 35[Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt, Gecko-windows7-32-opt, GitHub]

Chrome

FAIL : 1
TIMEOUT: 2
NOTRUN : 36

Safari

FAIL : 16
TIMEOUT: 2
NOTRUN : 21

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/cross-origin-opener-policy/reporting/access-reporting/property.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview], TIMEOUT [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)
cross-origin > w => w.blur(): FAIL (Chrome: FAIL, Safari: FAIL)
cross-origin > w => w.close(): FAIL (Chrome: TIMEOUT, Safari: FAIL)
same-site > w => w.opener: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
cross-origin > w => w["test"] = "": NOTRUN (Chrome: NOTRUN, Safari: FAIL)
same-site > w => w.window: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
same-site > w => w.blur(): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
same-site > w => w.focus(): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
cross-origin > w => w[0] = "": NOTRUN (Chrome: NOTRUN, Safari: FAIL)
cross-origin > w => w.postMessage("", ""): NOTRUN (Chrome: NOTRUN, Safari: FAIL)
cross-origin > w => w.top: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
cross-origin > w => w.opener = "": NOTRUN (Chrome: NOTRUN, Safari: FAIL)
same-site > w => w.top: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
cross-origin > w => w.location: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
same-site > w => w["test"]: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
cross-origin > w => w.location = "#": NOTRUN (Chrome: NOTRUN, Safari: FAIL)
cross-origin > w => w.length: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
same-site > w => w.opener = "": NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
same-site > w => w["test"] = "": NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
same-site > w => w.postMessage(""): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
cross-origin > w => w.closed: FAIL [Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows7-32-debug], TIMEOUT [Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt, Gecko-windows7-32-opt, GitHub] (Chrome: NOTRUN, Safari: FAIL)
same-site > w => w.location = "#": NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
cross-origin > w => w.self: NOTRUN (Chrome: NOTRUN, Safari: TIMEOUT)
same-site > w => w.postMessage("", ""): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
same-site > w => w.close(): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
same-site > w => w.frames: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
same-site > w => w.length: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
same-site > w => w.closed: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
same-site > w => w.self: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
cross-origin > w => w.opener: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
cross-origin > w => w.frames: FAIL [Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows7-32-debug], NOTRUN [Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt, Gecko-windows7-32-opt, GitHub] (Chrome: NOTRUN, Safari: FAIL)
cross-origin > w => w[0]: NOTRUN [Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt, Gecko-windows7-32-opt, GitHub], TIMEOUT [Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows7-32-debug] (Chrome: NOTRUN, Safari: FAIL)
same-site > w => w[0]: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
same-site > w => w.location: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
cross-origin > w => w.focus(): FAIL [Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows7-32-debug], NOTRUN [Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt, Gecko-windows7-32-opt, GitHub] (Chrome: NOTRUN, Safari: FAIL)
cross-origin > w => w["test"]: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
cross-origin > w => w.postMessage(""): NOTRUN (Chrome: NOTRUN, Safari: FAIL)
same-site > w => w[0] = "": NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
cross-origin > w => w.window: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)

Tests Disabled in Gecko Infrastructure

/html/cross-origin-opener-policy/reporting/access-reporting/property.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview], TIMEOUT [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/061cb62ee4fd [wpt PR 24687] - Revert "[COOP] access reporting [5/N] Plumb report type.", a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.