1654436 - Fix failing localStorage mochitests with cross-origin and Fission enabled

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P2)

Description

[Neha Kochar [:neha]]

These tests are marked as skipped/failed for cross-origin and Fission, and need to be fixed
dom/tests/mochitest/localstorage/test_localStorageCookieSettings.html

https://docs.google.com/spreadsheets/d/16G5AZhHWWow3rBgim4QBHzWXMIIJiky2SzXYgDMTTKY/edit#gid=1354562828&range=82:83

More info: https://wiki.mozilla.org/Project_Fission/Enabling_Tests_with_Fission#Cross-Origin_Mochitests

Comment 1

[Tom Tung [:tt, :ttung]]

I ran this test with ./mach test test_localStorageCookieSettings.html --enable-fission --enable-xorigin-tests and I saw JavaScript error: http://example.com/tests/dom/tests/mochitest/localstorage/frameLocalStorageCookieSettings.html, line 12: ReferenceError: is is not defined and UNEXPECTED-PASS fail-if condition in manifest - We expected at least one failure.

I wonder if the issue still exists or not. I will push a patch with replacing is with ok and remove the skip mark to try to see if the issue is still there or not.

Comment 2

[Tom Tung [:tt, :ttung]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=03beedde45b940defe267122c37a3d0c2e619fb6

Comment 3

[Tom Tung [:tt, :ttung]]

(In reply to Tom Tung [:tt, :ttung] from comment #2)

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=03beedde45b940defe267122c37a3d0c2e619fb6

Hmm, so there seem to have two issues for the test:
One is JavaScript error: http://example.com/tests/dom/tests/mochitest/localstorage/frameLocalStorageCookieSettings.html, line 12: ReferenceError: is is not defined and it can be fixed by adding <script src="/tests/SimpleTest/SimpleTest.js"></script> in frameLocalStorageCookieSettings.html
The other is UNEXPECTED-PASS fail-if condition in manifest - We expected at least one failure and it's https://searchfox.org/mozilla-central/rev/0e309417bdc73be33fc93f6bd7a0d4063d2c6e51/dom/tests/mochitest/localstorage/test_localStorageCookieSettings.html#49.

I cannot reproduce the latter one with ./mach test test_localStorageCookieSettings.html --enable-fission --enable-xorigin-tests on my machine. I will look into it more to see if I can find a way to reproduce this.

Comment 4

[Tom Tung [:tt, :ttung]]

(In reply to Tom Tung [:tt, :ttung] from comment #3)

(In reply to Tom Tung [:tt, :ttung] from comment #2)

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=03beedde45b940defe267122c37a3d0c2e619fb6

Hmm, so there seem to have two issues for the test:
One is JavaScript error: http://example.com/tests/dom/tests/mochitest/localstorage/frameLocalStorageCookieSettings.html, line 12: ReferenceError: is is not defined and it can be fixed by adding <script src="/tests/SimpleTest/SimpleTest.js"></script> in frameLocalStorageCookieSettings.html
The other is UNEXPECTED-PASS fail-if condition in manifest - We expected at least one failure and it's https://searchfox.org/mozilla-central/rev/0e309417bdc73be33fc93f6bd7a0d4063d2c6e51/dom/tests/mochitest/localstorage/test_localStorageCookieSettings.html#49.

I cannot reproduce the latter one with ./mach test test_localStorageCookieSettings.html --enable-fission --enable-xorigin-tests on my machine. I will look into it more to see if I can find a way to reproduce this.

I finally am able to reproduce the failure by executing: ./mach mochitest --enable-fission --enable-xorigin-tests --headless dom/tests/mochitest/localstorage*

*It appears you need to run a few tests together to trigger --enable-xorigin-tests

So, in the normal run (without enabling fission and xorigin)
aCookiePermission is set to UNKNOWN_ACTION here and aCookiePermission is set to DENY_ACTION in the run with enabling fission and xorigin.

It seems that it's an issue in permission manager such that cause this test to fail.

Tim, would you mind taking a look into this?

Comment 5

[Tom Tung [:tt, :ttung]]

After investigation and discussing with Tim, I think this is an issue in Storage Access/Permission. I am going to pass the ticket to Tim.

Comment 6

[Tim Huang[:timhuang]]

Attachment: Bug 1654436 - Part 1: Clean up the permissions for test 'test_cookieBlock.html'. r?ttung

Comment 7

[Tim Huang[:timhuang]]

Attachment: Bug 1654436 - Part 2: Fix the issue that is() doesn't work in frameLocalStorageCookieSettings.html. r?ttung

Depends on D87733

Comment 8

[Tim Huang[:timhuang]]

Attachment: Bug 1654436 - Part 3: Enable test_localStorageCookieSettings.html in Fission. r?ttung

Depends on D87734

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0eef665a95cf
Part 1: Clean up the permissions for test 'test_cookieBlock.html'. r=ttung
https://hg.mozilla.org/integration/autoland/rev/dd9484ede5cf
Part 2: Fix the issue that is() doesn't work in frameLocalStorageCookieSettings.html. r=ttung
https://hg.mozilla.org/integration/autoland/rev/d0dee27c5597
Part 3: Enable test_localStorageCookieSettings.html in Fission. r=ttung

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/0eef665a95cf
https://hg.mozilla.org/mozilla-central/rev/dd9484ede5cf
https://hg.mozilla.org/mozilla-central/rev/d0dee27c5597