Conditionally enable usage of JSWindowActor in Marionette
Categories
(Remote Protocol :: Marionette, enhancement, P1)
Tracking
(firefox80 fixed)
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [marionette-fission-mvp])
Attachments
(1 file)
From my investigation yesterday it's clear that we cannot run both the new JSWindowActor implementation and the old framescript in parallel. Main reason is that commands like Find Element and Find Elements would have to run both code paths and as such return two distinct element references, which is not possible. I also don't see an easy way to force a unique one.
As such I suggest that we hide all of our JSWindowActor work behind a preference like marionette.actors.enabled for now. I would have to be set in the Taskcluster job when running tests in CI.
We cannot bind this to Fission enabled given that certain test jobs as run for Fission in CI (like web-platform-tests) would completely fail. But once we are done with our transition we should indeed open it up for Fission jobs first to detect and fix remaining issues before a wider audience can make use of it.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8fc969622469 [marionette] Conditionally enable usage of JSWindowActor. r=marionette-reviewers,maja_zf
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•1 year ago
|
Description
•