Closed
Bug 1654469
Opened 5 years ago
Closed 5 years ago
Stop generating operator==/operator != for IPDL structs/unions by default
Categories
(Core :: IPC, task)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
References
Details
Attachments
(2 files)
Most IPDL structs/unions do not actually require an operator==/!=. Generating them unnecessarily increases compile times, and may require the manual implementation of operator==/!= on dependent native types, which are never called. The option introduced by Bug 1654181 should be inverted, i.e. require adding a comparable keyword to opt-in to the generation rather than using uncomparable to opt out.
Existing IPDL files that do require being comparable must be adapted as part of this.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61ccfaba8d85
Stop generating operator==/operator != for IPDL structs/unions by default. r=nika
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08c29f9d8779
Fix test protocol names. r=mccr8
|
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•