1654475 - SharedSurface_SurfaceTexture: Only ReleaseTexImage if IsSingleBuffer

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Sotaro Ikeda [:sotaro]]

SharedSurface_SurfaceTexture::ProducerReadReleaseImpl() handles java::GeckoSurfaceTexture. But it is very confusing. The GeckoSurfaceTexture is not SurfaceTexture of this class's GeckoSurface when current process is content process. SurfaceTexture of this class's GeckoSurface does not exist in this process. It exists in compositor's process. Then GeckoSurfaceTexture in this process is a sync surface that copies back the SurfaceTextrure from compositor's process.

Then it is better to add a comment to the function.

ProducerReadReleaseImpl() is added by Bug 1642994.

Comment 1

[Sotaro Ikeda [:sotaro]]

The following diagram might help to understand the relationship.
https://github.com/sotaroikeda/firefox-diagrams/blob/master/mobile/mobile_SurfaceAllocatorService_68.pdf

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1654475 - SharedSurface_SurfaceTexture: Only ReleaseTexImage if IsSingleBuffer

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c03b98619846
SharedSurface_SurfaceTexture: Only ReleaseTexImage if IsSingleBuffer r=jgilbert

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c03b98619846