1654476 - [Linux/Gtk] Firefox fails to paste text/html mime if content="text/html; is missing

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

Firefox fails to paste text/html mime if there are text/plain formats in clipboard on Linux/Gtk.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1855084

Comment 2

[Martin Stránský [:stransky] (ni? me)]

echo '<b>Bold</b><i>Italics</i>Plain' | wl-copy --type text/html

puts those targets at clipboard:

$xclip -o -t TARGETS

text/x-moz-url-priv
text/plain
text/plain;charset=utf-8
STRING
TEXT
COMPOUND_TEXT
UTF8_STRING
text/_moz_htmlinfo
text/_moz_htmlcontext
text/html
TARGETS
TIMESTAMP

echo '<b>Bold</b><i>Italics</i>Plain' | wl-copy

puts those targets at clipboard:

[komat@localhost ~]$ xclip -o -t TARGETS
text/plain
text/plain;charset=utf-8
STRING
TEXT
COMPOUND_TEXT
UTF8_STRING
TARGETS
TIMESTAMP

so the clipboard contains plain text along the html and other formats.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

It does not work because there's missing content="text/html; field so we failed to convert it at ConvertHTMLtoUCS2(). Maybe other applications (Chrome, OpenOffice) are not so strict and don't request the metadata.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1654476 [Linux/Gtk] Provide more logging to clipboard code, r?jhorak

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1654476 [Linux/Gtk] Fallback to utf-8 when charset is not set for text/html, r?jhorak

• Fallback to utf-8 when charset is not set for text/html.
• Move GetHTMLCharset() call out of ConvertHTMLtoUCS2() and use charset param there.
• Make GetHTMLCharset()/ConvertHTMLtoUCS2() return bool.

Depends on D84492

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1654476 [Linux/Gtk] GetHTMLCharset() logging fixes, r?jhorak

Depends on D84493

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af66e1ce7d9d
[Linux/Gtk] Provide more logging to clipboard code, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/a32f54d0690c
[Linux/Gtk] Fallback to utf-8 when charset is not set for text/html, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/955f20019d71
[Linux/Gtk] GetHTMLCharset() logging fixes, r=jhorak

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/af66e1ce7d9d
https://hg.mozilla.org/mozilla-central/rev/a32f54d0690c
https://hg.mozilla.org/mozilla-central/rev/955f20019d71