1654500 - Disabled date input shows wrong value when cleared programatically

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[IagoSRL]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

• Choose or set a valid value to a date input
• Disable the input (set attribute 'disabled' at the input element)
• Uses JavaScript to clear the value by assigning and empty string to the 'value' property (when selected at Inspector, $0.value = '').
• (example as a fiddle https://jsfiddle.net/IagoSRL/t1k9fy4x/16/)

Actual results:

• The input shows still the previously choosen date, as is nothing happened.
• But the 'value' property reports to be an empty string.
• And the 'valueAsDate' reports to be a null value.

Expected results:

• The input should display as empty (no date displayed)
• (note that, if rather an empty string another valid date is set, the display updates properly).

Comment 1

[IagoSRL]

It happens at Nightly "80.0a1 (2020-07-21) (64-bit)" too.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Jim Mathies [:jimm]]

I think this should stay in DOM, it does not sound like a widget (rendering) bug.

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

https://searchfox.org/mozilla-central/rev/e07d5eb5646b40b10df3164e315d4a3108cf9101/toolkit/content/widgets/datetimebox.js#800

clearInputFields() in datetimebox.js is no-op when the element is disabled (isEditable() is false when disabled), so the component.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Oh, but Widget is about OS level widgets. This is more like a toolkit issue or Core & HTML or Layout.
The parent process side of form elements is vague.

Comment 7

[Sean Voisen (:svoisen)]

Fun. It's not really a layout issue though (unless it had to do with widget sizing or styling). Generally the agreement we've had is that functionality of non-OS level widgets would stay in DOM: Core & HTML. I'll leave in Layout for now since we're touching form controls in various ways soon.

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

Taking this as I already found the cause in comment #5.

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1654500 - Clear disabled/readonly datetime input fields r=smaug

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17a6a7569efc
Clear disabled/readonly datetime input fields r=smaug

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/17a6a7569efc