1654516 - Optimize some more intrinsics in CacheIR and Warp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1654516 part 1 - Optimize _IsConstructing intrinsic in CacheIR and Warp. r?iain!

This is a pretty big performance improvement for bound functions in Baseline.

The transpiler part was non-trivial becuase the transpiler has to know whether
we're inlining and constructing. Instead of adding yet another argument to
TranspileCacheIRToMIR, this passes the WarpBuilder so we can use its inlineCallInfo.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1654516 part 2 - Optimize the IsCrossRealmArrayConstructor intrinsic in CacheIR and Warp. r?anba!

I also added GuardIsNotProxy/MGuardIsNotProxy because it seemed like a useful
primitive to have.

Depends on D84517

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1654516 part 3 - Optimize the GetNext{Map,Set}EntryForIterator intrinsics in CacheIR and Warp. r?anba!

Also changes the signatures of the 'next' methods so we can call them with callWithABI.

Depends on D84670

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1654516 part 4 - Optimize the FinishBoundFunctionInit intrinsic in CacheIR and Warp. r?anba!

The IC code just does a callVM for now. This required adding AutoCallVM::callNoResult
to avoid confusing storeCallResult.

Depends on D84671

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1654516 part 3 - Optimize the GetNext{Map,Set}EntryForIterator intrinsics in CacheIR and Warp. r?anba!

Also changes the signatures of the 'next' methods so we can call them with callWithABI.

Depends on D84670

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1152d7b452a9
part 1 - Optimize _IsConstructing intrinsic in CacheIR and Warp. r=iain
https://hg.mozilla.org/integration/autoland/rev/fb2ba023ba98
part 2 - Optimize the IsCrossRealmArrayConstructor intrinsic in CacheIR and Warp. r=anba
https://hg.mozilla.org/integration/autoland/rev/502c18eb1a04
part 3 - Optimize the GetNext{Map,Set}EntryForIterator intrinsics in CacheIR and Warp. r=anba
https://hg.mozilla.org/integration/autoland/rev/664d5871886b
part 4 - Optimize the FinishBoundFunctionInit intrinsic in CacheIR and Warp. r=anba

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1152d7b452a9
https://hg.mozilla.org/mozilla-central/rev/fb2ba023ba98
https://hg.mozilla.org/mozilla-central/rev/502c18eb1a04
https://hg.mozilla.org/mozilla-central/rev/664d5871886b