Closed Bug 1654528 Opened 2 months ago Closed 2 months ago

Update comments for branding in Firefox

Categories

(Mozilla Localizations :: Other, task)

Tracking

(firefox80 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox80 --- fixed

People

(Reporter: flod, Assigned: flod)

Details

Attachments

(1 file)

I realized a while ago that most our comments point to a non-existing page on mozilla.org, and still prohibit declensions.

I need more context here. Could you be more clear about what is needed for this bug and where?

(In reply to Jeff Beatty [:gueroJeff] from comment #1)

I need more context here. Could you be more clear about what is needed for this bug and where?

You were too fast, I'm writing a patch…

@Jeff

I wanted to have you confirm if the new wording makes sense, and ask Axel to review the technical bits on the change. But it looks like you don't have an account on Phabricator, so asking here in the bug.
https://phabricator.services.mozilla.com/D84497

You can see that the existing comment points to https://www.mozilla.org/styleguide/communications/translation/, which was removed a long time ago.

I was able to look at it, and it all lgtm.

(In reply to Jeff Beatty [:gueroJeff] from comment #5)

I was able to look at it, and it all lgtm.

Thanks, over to Axel in Phabricator then.

Pushed by flodolo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6667ef560491
Update comments for brand names in Fluent files r=Pike
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.