1654528 - Update comments for branding in Firefox

Status: RESOLVED FIXED

(Mozilla Localizations :: Other, task)

Description

[Francesco Lodolo [:flod]]

I realized a while ago that most our comments point to a non-existing page on mozilla.org, and still prohibit declensions.

Comment 1

[Jeff Beatty [:gueroJeff]]

I need more context here. Could you be more clear about what is needed for this bug and where?

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Jeff Beatty [:gueroJeff] from comment #1)

I need more context here. Could you be more clear about what is needed for this bug and where?

You were too fast, I'm writing a patch…

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Bug 1654528 - Update comments for brand names in Fluent files

Comment 4

[Francesco Lodolo [:flod]]

@Jeff

I wanted to have you confirm if the new wording makes sense, and ask Axel to review the technical bits on the change. But it looks like you don't have an account on Phabricator, so asking here in the bug.
https://phabricator.services.mozilla.com/D84497

You can see that the existing comment points to https://www.mozilla.org/styleguide/communications/translation/, which was removed a long time ago.

Comment 5

[Jeff Beatty [:gueroJeff]]

I was able to look at it, and it all lgtm.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Jeff Beatty [:gueroJeff] from comment #5)

I was able to look at it, and it all lgtm.

Thanks, over to Axel in Phabricator then.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6667ef560491
Update comments for brand names in Fluent files r=Pike

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6667ef560491