1654546 - No shield icon in the url bar when the top-level page is sandboxed

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P2)

Description

[Dimi Lee [:dimi]]

Details can be found in Bug 1647681 Comment 0.

Comment 1

[Emma Zühlcke [:emz]]

Seems like the protection panel works fine with a nullprincipal, except for the TP toggle. It's currently disabled by the check here:
https://searchfox.org/mozilla-central/rev/f081504642a115cb8236bea4d8250e5cb0f39b02/toolkit/components/antitracking/ContentBlockingAllowList.jsm#49 (isContentPrincipal).
Disabling / hiding the toggle for the top level sandbox case would work, but then the user loses the ability to turn TP off. I'll look into how we can persist the trackingprotection permission for the top level sandbox case.

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1654546 - Construct contentBlockingAllowListPrincipal with documentURI to avoid NullPrincipal. r=timhuang

The document principal of pages with top level sandbox is a NullPrincipal, which resulted in
contentBlockingAllowListPrincipal also being a NullPrincipal. This prevented us from showing the
trackingprotection panel in the frontend for top level sandboxed sites.
This patch updates ContentBlockingAllowList::ComputePrincipal to construct the principal by document URI
rather than just the document principal.

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 1654546 - Test that we show the protection UI for top level sandboxed pages. r=timhuang

Depends on D98054

Comment 4

[Emma Zühlcke [:emz]]

Attachment: Bug 1654546 - Don't set contentBlockingAllowListPrincipal to NullPrincipal for sandboxed documents. r=timhuang

Comment 5

[Emma Zühlcke [:emz]]

Attachment: Bug 1654546 - Added test for the contentBlockingAllowListPrincipal. r=timhuang

Depends on D98055

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7c2aad1aade
Don't set contentBlockingAllowListPrincipal to NullPrincipal for sandboxed documents. r=timhuang,emilio
https://hg.mozilla.org/integration/autoland/rev/0796dd620879
Test that we show the protection UI for top level sandboxed pages. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/101d2f54673f
Added test for the contentBlockingAllowListPrincipal. r=timhuang

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e7c2aad1aade
https://hg.mozilla.org/mozilla-central/rev/0796dd620879
https://hg.mozilla.org/mozilla-central/rev/101d2f54673f

Comment 8

[Ciprian Georgiu, Desktop QA]

I have managed to reproduce this bug using the test page from bug 1647681#c0, the shield icon was not displayed on an affected Nightly build (79.0a1, 20200623213840).

The issue is verified as fixed on latest Beta 85.0b4 (20201220193140) under macOS 10.15, Windows 10 x64 and Ubuntu 18.04 x64.