1654556 - Log also "failed the samesite tests" cookie rejection reason.

Status: RESOLVED FIXED

(Core :: Networking: Cookies, enhancement, P2)

Description

[Honza Bambas (:mayhemer)]

The place is here.

Comment 1

[Honza Bambas (:mayhemer)]

We already have the Some cookies are misusing the “SameSite“ attribute, so it won’t work as expected logging to the web console, which is kind of a warning. But doesn't say that the cookies are rejected, so I think this bug is still worth doing.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: Bug 1654556 - Log also "failed the samesite tests" cookie rejection reason, r=baku

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29ae67e7f8d5
Log also "failed the samesite tests" cookie rejection reason, r=baku

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 29ae67e7f8d5 (bug 1654556) for browser_webconsole_warning_group_storage_isolation.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=mochitest-devtools&fromchange=df5996370d1d281c6ce6695958d1f15f76fa83b9&tochange=f17ec23cf6d58b304ae539b46116eaf97016a911&selectedTaskRun=SYOb925tTlu08koH0kGQVQ.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/f17ec23cf6d58b304ae539b46116eaf97016a911

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310832406&repo=autoland&lineNumber=4730

[task 2020-07-23T12:18:27.543Z] 12:18:27     INFO - TEST-START | devtools/client/webconsole/test/browser/browser_webconsole_warning_group_storage_isolation.js
[task 2020-07-23T12:18:30.726Z] 12:18:30     INFO - TEST-INFO | started process screentopng
[task 2020-07-23T12:18:31.073Z] 12:18:31     INFO - TEST-INFO | screentopng: exit 0
[task 2020-07-23T12:18:31.073Z] 12:18:31     INFO - Buffered messages logged at 12:18:27
[task 2020-07-23T12:18:31.074Z] 12:18:31     INFO - Entering test bound testStorageIsolationMessage
[task 2020-07-23T12:18:31.074Z] 12:18:31     INFO - Buffered messages logged at 12:18:28
[task 2020-07-23T12:18:31.074Z] 12:18:31     INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/webconsole/test/browser/test-warning-groups.html
[task 2020-07-23T12:18:31.074Z] 12:18:31     INFO - Tab added and finished loading
[task 2020-07-23T12:18:31.074Z] 12:18:31     INFO - Buffered messages logged at 12:18:29
[task 2020-07-23T12:18:31.075Z] 12:18:31     INFO - Test storage isolation message
[task 2020-07-23T12:18:31.075Z] 12:18:31     INFO - Buffered messages logged at 12:18:30
[task 2020-07-23T12:18:31.075Z] 12:18:31     INFO - Console message: [JavaScript Warning: "Cookie “name” has been rejected because it is in a cross-site context and its “SameSite” is “Lax” or “Strict”." {file: "http://example.org/browser/devtools/client/webconsole/test/browser/cookieSetter.html?1&1595506709947" line: 5}]
[task 2020-07-23T12:18:31.076Z] 12:18:31     INFO - Console message: [JavaScript Warning: "Partitioned cookie or storage access was provided to “http://example.org/browser/devtools/client/webconsole/test/browser/cookieSetter.html?1&1595506709947” because it is loaded in the third-party context and storage partitioning is enabled."]
[task 2020-07-23T12:18:31.076Z] 12:18:31     INFO - Matched a message with text: "Partitioned cookie or storage access was provided to “http://example.org/browser/devtools/client/webconsole/test/browser/cookieSetter.html?1&1595506709947” because it is loaded in the third-party context and storage partitioning is enabled.", all messages received.
[task 2020-07-23T12:18:31.076Z] 12:18:31     INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_warning_group_storage_isolation.js | The storage isolation message was displayed - 
[task 2020-07-23T12:18:31.076Z] 12:18:31     INFO - Emit a new storage isolation message to check that it causes a grouping
[task 2020-07-23T12:18:31.077Z] 12:18:31     INFO - Console message: [JavaScript Warning: "Cookie “name” has been rejected because it is in a cross-site context and its “SameSite” is “Lax” or “Strict”." {file: "http://example.org/browser/devtools/client/webconsole/test/browser/cookieSetter.html?2&1595506709947" line: 5}]
[task 2020-07-23T12:18:31.078Z] 12:18:31     INFO - Console message: [JavaScript Warning: "Partitioned cookie or storage access was provided to “http://example.org/browser/devtools/client/webconsole/test/browser/cookieSetter.html?2&1595506709947” because it is loaded in the third-party context and storage partitioning is enabled."]
[task 2020-07-23T12:18:31.079Z] 12:18:31     INFO - Matched a message with text: "Partitioned cookie or storage access was provided to “<URL>” because it is loaded in the third-party context and storage partitioning is enabled.", all messages received.
[task 2020-07-23T12:18:31.079Z] 12:18:31     INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_warning_group_storage_isolation.js | The badge has the expected text - 
[task 2020-07-23T12:18:31.081Z] 12:18:31     INFO - Buffered messages finished
[task 2020-07-23T12:18:31.081Z] 12:18:31     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_warning_group_storage_isolation.js | Got the expected number of messages - Got 3, expected 1
[task 2020-07-23T12:18:31.081Z] 12:18:31     INFO - Stack trace:
[task 2020-07-23T12:18:31.082Z] 12:18:31     INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-07-23T12:18:31.082Z] 12:18:31     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:checkConsoleOutputForWarningGroup:1528
[task 2020-07-23T12:18:31.084Z] 12:18:31     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_warning_group_storage_isolation.js:testStorageIsolationMessage:74
[task 2020-07-23T12:18:31.085Z] 12:18:31     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-07-23T12:18:31.086Z] 12:18:31     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-07-23T12:18:31.087Z] 12:18:31     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-07-23T12:18:31.088Z] 12:18:31     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:1032
[task 2020-07-23T12:18:31.089Z] 12:18:31     INFO - Checking "▶︎⚠ Partitioned cookie or storage access was provided to “<URL>” because it is loaded in the third-party context and storage partitioning is enabled. 2"
[task 2020-07-23T12:18:31.090Z] 12:18:31     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-07-23T12:18:31.091Z] 12:18:31     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_warning_group_storage_isolation.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:1557 - TypeError: can't access property "getAttribute", message.querySelector(...) is null
[task 2020-07-23T12:18:31.092Z] 12:18:31     INFO - Stack trace:
[task 2020-07-23T12:18:31.093Z] 12:18:31     INFO - checkConsoleOutputForWarningGroup/<@chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:1557:17
[task 2020-07-23T12:18:31.093Z] 12:18:31     INFO - checkConsoleOutputForWarningGroup@chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:1550:20
[task 2020-07-23T12:18:31.093Z] 12:18:31     INFO - testStorageIsolationMessage@chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_warning_group_storage_isolation.js:74:36
[task 2020-07-23T12:18:31.093Z] 12:18:31     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1064:34
[task 2020-07-23T12:18:31.093Z] 12:18:31     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1104:11
[task 2020-07-23T12:18:31.093Z] 12:18:31     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:927:14
[task 2020-07-23T12:18:31.093Z] 12:18:31     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1032:23
[task 2020-07-23T12:18:31.093Z] 12:18:31     INFO - Leaving test bound testStorageIsolationMessage
[task 2020-07-23T12:18:31.093Z] 12:18:31     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-07-23T12:18:31.094Z] 12:18:31     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_warning_group_storage_isolation.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2020-07-23T12:18:31.094Z] 12:18:31     INFO - Stack trace:
[task 2020-07-23T12:18:31.094Z] 12:18:31     INFO - chrome://mochikit/content/browser-test.js:test_ok:1299
[task 2020-07-23T12:18:31.094Z] 12:18:31     INFO - chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:cleanup:307
[task 2020-07-23T12:18:31.094Z] 12:18:31     INFO - GECKO(2815) | MEMORY STAT | vsize 20977631MB | residentFast 3852MB
[task 2020-07-23T12:18:31.094Z] 12:18:31     INFO - TEST-OK | devtools/client/webconsole/test/browser/browser_webconsole_warning_group_storage_isolation.js | took 3288ms
[task 2020-07-23T12:18:31.094Z] 12:18:31     INFO - checking window state
[task 2020-07-23T12:18:31.094Z] 12:18:31     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-07-23T12:18:31.095Z] 12:18:31     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_warning_group_storage_isolation.js | Found an unexpected browser window at the end of test run - 
[task 2020-07-23T12:18:31.095Z] 12:18:31     INFO - GECKO(2815) | must wait for focus

Comment 5

[Honza Bambas (:mayhemer)]

This was a race with bug 1649280. Need a rebase and a fix now.

Comment 6

[Honza Bambas (:mayhemer)]

Attachment: Bug 1654556 - Update webconsole tests to not produce cookie same-siteness rejection warnings and thus not fail, r=nhnt11

Depends on D84555

Comment 7

[Honza Bambas (:mayhemer)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d09ca44fac46c09cb8aa23fb07f8ca472a4a790

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c6272a20ddd
Log also "failed the samesite tests" cookie rejection reason, r=baku
https://hg.mozilla.org/integration/autoland/rev/95bc4d15b66a
Update webconsole tests to not produce cookie same-siteness rejection warnings and thus not fail, r=nhnt11

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2c6272a20ddd
https://hg.mozilla.org/mozilla-central/rev/95bc4d15b66a