1654564 - MOZ_TRY_VAR documentation is wrong about the requirements for target

Status: RESOLVED FIXED

(Core :: MFBT, task)

Description

[Simon Giesecke [:sg] [he/him]]

That doesn't sound right: |target| must evaluate to a reference without any side effects.This sounds as if decltype(target) would need to be a reference, which is not true. In the typical use as in int x; MOZ_TRY_VAR(x, Task()), it is not a reference. While it might be a reference, this seems to be a more awkward use.

I think what this intends to say is: |target| must be an lvalue

(Not sure what the side effects part is intended to say)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1654564 - Fix documentation of requirements on target in MOZ_TRY_VAR. r=froydnj

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ed46d7477e1
Fix documentation of requirements on target in MOZ_TRY_VAR. r=froydnj

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8ed46d7477e1