1654569 - Keep BrowsingContextGroup alive throughout process switch

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P3)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1654569 - Keep BrowsingContextGroup alive throughout the process switch,

This builds on the new API added in bug 1652085 to reduce the chance of a
different BrowsingContextGroup instance being used for process selection at the
start of a process switch, and BrowsingContext creation at the end.

While this would probably not be a serious issue right now, as we always have
only a single "extension" process, it could become an issue in the future if the
specific group specifier is used in more places.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4388af0c7d95
Keep BrowsingContextGroup alive throughout the process switch, r=farre,annyG

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4388af0c7d95

Comment 4

[Atila Butkovits]

Backed out for assertion failure nsDocShell.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f4703bddd567ffe954073b70a7fe1b4dfa752281

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Creftests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-crashtest-fis-e10s%2Cc&revision=4388af0c7d953456560be39fe8289da18a94a53e&selectedTaskRun=Zi9USHhzTUqKXJBxunUGAw.0

Retriggers:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Creftests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-crashtest-fis-e10s%2Cc&fromchange=ab1ea3d6a1bd4df86cebe569478d31c0766c6197

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311069692&repo=autoland&lineNumber=3239

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f4703bddd567

Comment 6

[Atila Butkovits]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/f4703bddd567ffe954073b70a7fe1b4dfa752281

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bc79ab06f0a
Keep BrowsingContextGroup alive throughout the process switch, r=farre,annyG

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4bc79ab06f0a