Closed Bug 1654622 Opened 2 months ago Closed 2 months ago

Replace Blob forward declaration with a BlobImpl forward declaration in MediaRecorder.h

Categories

(Core :: Audio/Video, task)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: rpl, Assigned: rpl)

Details

Attachments

(1 file)

From time to time I'm getting a build failure when I'm doing an incremental build locally:

 0:11.25 In file included from UnifiedBindings12.cpp:2:
 0:11.25 In file included from /.../obj-x86_64-pc-linux-gnu/dom/bindings/MediaRecorderBinding.cpp:8:
 0:11.25 /.../obj-x86_64-pc-linux-gnu/dist/include/MediaRecorder.h:124:39: error: unknown type name 'BlobImpl'
 0:11.25   nsresult CreateAndDispatchBlobEvent(BlobImpl* aBlobImpl);
 0:11.25                                       ^
 0:11.25 1 error generated.

Honestly I'm not sure why I'm not always see it triggered on all incremental builds (but I didn't dig too much into that).

Anyway the Blob class isn't used anymore in MediaRecorder.h starting from Bug 1585284, when nsresult CreateAndDispatchBlobEvent(Blob* aBlob); has been replaced by nsresult CreateAndDispatchBlobEvent(BlobImpl* aBlobImpl); and so the build error seems still legit, and the single line change in the attached patch does fix the build error.

Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/06a96da367fe
Replace Blob forward declaration with a BlobImpl forward declaration in MediaRecorder.h. r=bryce
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.