File properties of Firefox/Thunderbird Setup 78.0.1.exe show wrong product version / file version number (18.05 / 18.5.0.0)
Categories
(Firefox :: Installer, defect)
Tracking
()
People
(Reporter: thomas8, Unassigned)
Details
Attachments
(1 file)
Screenshot: Details tab of installation file properties on Win10 with wrong product version
Once in a while, we might want to update the internal properties of our installation files...
STR:
- On Windows 10, right-click on
Thunderbird Setup 78.0.1.exe> Properties > Details.
Actual Result:
- Product version: 18.05
- File version: 18.5.0.0
Expected result:
- Product version: 78.0.1
- File version: (not sure what that should be, maybe same as product version)
- Is there a way of adding a custom property to indicate 32 bit vs. 64 bit?
|
||
Comment 1•5 years ago
|
||
Rob, any idea where this comes from. It's showing the same for beta.
|
||
Comment 2•5 years ago
|
||
That value is wrong on Firefox installers as well going back to 52.9.0 and beyond. (I stopped there.)
Anyway, it's defined in the NSIS installer code:
https://searchfox.org/comm-central/source/mail/installer/windows/nsis/defines.nsi.in#9,87-97
and the value of MOZ_APP_VERSION is set here:
https://searchfox.org/comm-central/source/mail/installer/windows/moz.build#11
and that CONFIG['MOZ_APP_VERSION'] is found at configure time by reading the version.txt files.
And after a build, I checked the generated installer files and everything looks good there.
But.... it's not what you see because of the self-extracting stub 7zSD.sfx at https://searchfox.org/comm-central/source/other-licenses/7zstub/thunderbird.
That's just an EXE that is prepended to the actual installer after it's been UPX'd and 7zipped. This is evidenced by the "Original Filename" field that says "7zS.sfx.exe". And if you look at the resource file, it comes together: https://searchfox.org/mozilla-central/source/other-licenses/7zstub/firefox/resource.rc
The missing piece is that somewhere along the line Richard I believe uses a resource hacker tool on the Firefox build of 7zSD.sfx and updates the icon and product name data.
Whether or not that value can be updated at build time without recompiling the whole sfx stub, I don't know. I'd think that if it were easily doable the Firefox team would have by now.
|
|
||
Comment 3•5 years ago
|
||
Moving this bug to Firefox installer. Looks like the numbers are coming from here: https://searchfox.org/mozilla-central/rev/1843375acbbca68127713e402be222350ac99301/other-licenses/7zstub/src/C/7zVersion.h#1-5
If they can't be updated dynamically easily, maybe they should just be left out?
|
||
Comment 4•5 years ago
|
||
Thanks for the redirect. The analysis here is exactly correct about what's going on; thanks to Rob and Magnus for having a look.
The problem is indeed that, while updating the VERSIONINFO resource can be done manually, we don't really have a way to do so automatically while building the installer without recompiling the 7-zip SFX stub. And that really isn't possible either because a) it's built offline using a different toolchain from the rest of the build, and b) we don't necessarily have access to a C++ toolchain configuration during the installer phase of the build.
Another dup of this bug has been WONTFIX'd before, and I'm afraid that status has not changed since then. :(
Description
•