Closed Bug 1654679 Opened 4 years ago Closed 4 years ago

Add selected text marker range to text selection changed events

Categories

(Core :: Disability Access APIs, defect, P1)

Product:
Core
Component:
Disability Access APIs
Platform:
All
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Whiteboard: [mac2020_1])

Attachments

(1 file)

Bug 1654679 - Add selected text marker range to text selection changed events. r?morgan
47 bytes, text/x-phabricator-request
Details | Review

Adding the range to the event's userinfo allows VoiceOver to read the correct character the caret goes past, or range of characters that are selected.

Assignee: nobody → eitan
Status: NEW → ASSIGNED
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/290c72f07e0c
Add selected text marker range to text selection changed events. r=morgan

Backed out changeset 290c72f07e0c (bug 1654679) for es lint failure on browser_text_input.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=290c72f07e0ca171c3fb52d12c59dfe042961b42&searchStr=linting%2Copt%2Cjavascript%2Cchecks%2Csource-test-mozlint-eslint%2Ces&tochange=23db803b50cc4d173694068a10297ff9d29a7e6b&selectedTaskRun=L4dNPOXvRWuXS3O_Pvn5Cg.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/23db803b50cc4d173694068a10297ff9d29a7e6b

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310811208&repo=autoland&lineNumber=256

[task 2020-07-23T05:48:43.469Z] 05:48:43.468 eslint (96) | Command: /usr/local/bin/node /builds/worker/checkouts/gecko/node_modules/eslint/bin/eslint.js --ext [js,jsm,jsx,xul,html,xhtml] --format json --no-error-on-unmatched-pattern --quiet --ignore-pattern media/openmax_dl --ignore-pattern js/src/vtune/legacy --ignore-pattern media/mtransport/third_party --ignore-pattern js/src/vtune/ittnotify_static.c --ignore-pattern media/libopus --ignore-pattern media/libspeex_resampler --ignore-pattern ipc/chromium/src/third_party --ignore-pattern media/mp4parse-rust --ignore-pattern media/libmkv --ignore-pattern media/libnestegg --ignore-pattern js/src/vtune/ittnotify.h --ignore-pattern media/kiss_fft --ignore-pattern parser/expat --ignore-pattern js/src/vtune/jitprofiling.c --ignore-pattern netwerk/dns/nsIDNKitInterface.h --ignore-pattern media/libsoundtouch --ignore-pattern js/src/zydis --ignore-pattern js/src/jit/arm64/vixl --ignore-pattern media/libjpeg --ignore-pattern js/src/dtoa.c --ignore-pattern intl/icu --ignore-pattern media/libtremor --ignore-pattern js/src/vtune/jitprofiling.h --ignore-pattern media/libvorbis --ignore-pattern media/libvpx --ignore-pattern js/src/vtune/ittnotify_types.h --ignore-pattern media/openmax_il --ignore-pattern netwerk/srtp/src --ignore-pattern intl/unicharutil/util/nsUnicodePropertyData.cpp --ignore-pattern js/src/editline --ignore-pattern media/libwebp --ignore-pattern media/libaom --ignore-pattern media/libpng --ignore-pattern media/ffvpx --ignore-pattern netwerk/sctp/src --ignore-pattern js/src/vtune/ittnotify_static.h --ignore-pattern js/src/vtune/ittnotify_config.h --ignore-pattern intl/unicharutil/util/nsUnicodeScriptCodes.h --ignore-pattern media/webrtc/trunk --ignore-pattern media/libyuv --ignore-pattern media/libcubeb --ignore-pattern media/libogg --ignore-pattern js/src/vtune/disable_warnings.h --ignore-pattern js/src/octane --ignore-pattern editor/libeditor/tests/browserscope/lib --ignore-pattern media/webrtc/signaling/src/sdp/sipcc --ignore-pattern media/libtheora --ignore-pattern intl/unicharutil/util/nsSpecialCasingData.cpp --ignore-pattern media/libdav1d --ignore-pattern js/src/ctypes/libffi /builds/worker/checkouts/gecko/parser /builds/worker/checkouts/gecko/caps /builds/worker/checkouts/gecko/taskcluster /builds/worker/checkouts/gecko/startupcache /builds/worker/checkouts/gecko/js /builds/worker/checkouts/gecko/chrome /builds/worker/checkouts/gecko/media /builds/worker/checkouts/gecko/netwerk /builds/worker/checkouts/gecko/ipc /builds/worker/checkouts/gecko/accessible /builds/worker/checkouts/gecko/hal /builds/worker/checkouts/gecko/editor /builds/worker/checkouts/gecko/intl
[task 2020-07-23T05:48:43.516Z] 05:48:43.516 eslint (98) | Passing the following paths:
[task 2020-07-23T05:48:43.517Z] /builds/worker/checkouts/gecko/widget  
[task 2020-07-23T05:48:43.517Z] /builds/worker/checkouts/gecko/build  
[task 2020-07-23T05:48:43.517Z] /builds/worker/checkouts/gecko/modules  
[task 2020-07-23T05:48:43.517Z] /builds/worker/checkouts/gecko/tools  
[task 2020-07-23T05:48:43.517Z] /builds/worker/checkouts/gecko/config  
[task 2020-07-23T05:48:43.517Z] /builds/worker/checkouts/gecko/xpcom  
[task 2020-07-23T05:48:43.517Z] /builds/worker/checkouts/gecko/dom  
[task 2020-07-23T05:48:43.517Z] /builds/worker/checkouts/gecko/xpfe  
[task 2020-07-23T05:48:43.517Z] /builds/worker/checkouts/gecko/testing  
[task 2020-07-23T05:48:43.517Z] /builds/worker/checkouts/gecko/remote  
[task 2020-07-23T05:48:43.517Z] /builds/worker/checkouts/gecko/gfx  
[task 2020-07-23T05:48:43.517Z] /builds/worker/checkouts/gecko/browser
[task 2020-07-23T05:48:43.525Z] 05:48:43.524 eslint (98) | Command: /usr/local/bin/node /builds/worker/checkouts/gecko/node_modules/eslint/bin/eslint.js --ext [js,jsm,jsx,xul,html,xhtml] --format json --no-error-on-unmatched-pattern --quiet --ignore-pattern testing/web-platform/tests/resources/webidl2 --ignore-pattern dom/media/webspeech/recognition/endpointer.h --ignore-pattern gfx/ycbcr --ignore-pattern modules/zlib --ignore-pattern dom/media/webspeech/recognition/energy_endpointer_params.h --ignore-pattern dom/media/gmp/widevine-adapter/content_decryption_module_proxy.h --ignore-pattern modules/brotli --ignore-pattern dom/tests/mochitest/dom-level2-core --ignore-pattern testing/mochitest/tests/MochiKit-1.4.2 --ignore-pattern gfx/angle/checkout --ignore-pattern gfx/sfntly --ignore-pattern dom/media/webvtt/vtt.jsm --ignore-pattern dom/media/webspeech/recognition/energy_endpointer.h --ignore-pattern testing/talos/talos/tests/v8_7 --ignore-pattern gfx/graphite2 --ignore-pattern testing/modules/ajv-4.1.1.js --ignore-pattern testing/web-platform/tests/tools/third_party --ignore-pattern dom/media/gmp/widevine-adapter/content_decryption_module_export.h --ignore-pattern gfx/vr/service/openvr --ignore-pattern modules/fdlibm --ignore-pattern dom/canvas/test/webgl-conf/checkout --ignore-pattern xpcom/build/mach_override.c --ignore-pattern browser/extensions/formautofill/content/third-party --ignore-pattern testing/xpcshell/node-http2 --ignore-pattern tools/fuzzing/libfuzzer --ignore-pattern dom/tests/mochitest/dom-level2-html --ignore-pattern dom/media/platforms/ffmpeg/libav55 --ignore-pattern dom/media/gmp/widevine-adapter/content_decryption_module_ext.h --ignore-pattern testing/gtest/gmock --ignore-pattern dom/media/platforms/ffmpeg/libav54 --ignore-pattern dom/media/gmp/widevine-adapter/content_decryption_module.h --ignore-pattern dom/media/gmp/rlz --ignore-pattern testing/talos/talos/tests/dromaeo --ignore-pattern gfx/cairo --ignore-pattern gfx/wr --ignore-pattern testing/xpcshell/dns-packet --ignore-pattern dom/media/platforms/ffmpeg/ffmpeg57 --ignore-pattern dom/media/webspeech/recognition/endpointer.cc --ignore-pattern gfx/harfbuzz --ignore-pattern testing/mozbase/mozproxy/mozproxy/backends/mitm/scripts/catapult --ignore-pattern dom/tests/mochitest/dom-level1-core --ignore-pattern testing/gtest/gtest --ignore-pattern dom/media/platforms/ffmpeg/libav53 --ignore-pattern browser/extensions/screenshots/build/raven.js --ignore-pattern gfx/ots --ignore-pattern dom/media/platforms/ffmpeg/ffmpeg58 --ignore-pattern dom/webauthn/tests/pkijs --ignore-pattern remote/test/puppeteer --ignore-pattern dom/media/webaudio/test/blink --ignore-pattern xpcom/io/crc32c.c --ignore-pattern browser/components/translation/cld2 --ignore-pattern dom/tests/mochitest/ajax --ignore-pattern testing/modules/sinon-7.2.7.js --ignore-pattern browser/components/newtab/vendor --ignore-pattern tools/lint/test/files --ignore-pattern testing/mochitest/pywebsocket3 --ignore-pattern modules/freetype2 --ignore-pattern dom/webauthn/cbor-cpp --ignore-pattern dom/media/webspeech/recognition/energy_endpointer_params.cc --ignore-pattern testing/xpcshell/node-ip --ignore-pattern testing/mochitest/MochiKit --ignore-pattern gfx/skia --ignore-pattern browser/components/pocket/content/panels/js/vendor --ignore-pattern dom/imptests --ignore-pattern testing/talos/talos/tests/kraken --ignore-pattern tools/profiler/core/vtune --ignore-pattern dom/u2f/tests/pkijs --ignore-pattern xpcom/build/mach_override.h --ignore-pattern gfx/qcms --ignore-pattern remote/test/browser/chrome-remote-interface.js --ignore-pattern modules/xz-embedded --ignore-pattern modules/woff2 --ignore-pattern dom/media/webspeech/recognition/energy_endpointer.cc /builds/worker/checkouts/gecko/widget /builds/worker/checkouts/gecko/build /builds/worker/checkouts/gecko/modules /builds/worker/checkouts/gecko/tools /builds/worker/checkouts/gecko/config /builds/worker/checkouts/gecko/xpcom /builds/worker/checkouts/gecko/dom /builds/worker/checkouts/gecko/xpfe /builds/worker/checkouts/gecko/testing /builds/worker/checkouts/gecko/remote /builds/worker/checkouts/gecko/gfx /builds/worker/checkouts/gecko/browser
[task 2020-07-23T05:50:11.211Z] 05:50:11.211 eslint (96) | Finished in 87.89 seconds
[task 2020-07-23T05:53:24.916Z] 05:53:24.916 eslint (99) | Finished in 281.59 seconds
[task 2020-07-23T05:54:06.071Z] 05:54:06.71 eslint (97) | Finished in 322.75 seconds
[task 2020-07-23T05:55:54.984Z] 05:55:54.984 eslint (98) | Finished in 431.66 seconds
[task 2020-07-23T05:55:54.989Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/accessible/tests/browser/mac/browser_text_input.js:97:8 | 'webareaEvent' is assigned a value but never used. (no-unused-vars)
[taskcluster 2020-07-23 05:55:55.651Z] === Task Finished ===
[taskcluster 2020-07-23 05:55:55.928Z] Unsuccessful task run with exit code: 1 completed in 585.171 seconds
Flags: needinfo?(eitan)
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8848caa5b125
Add selected text marker range to text selection changed events. r=morgan
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47667fbae734
Add selected text marker range to text selection changed events. r=morgan
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/319d295b5294
Add selected text marker range to text selection changed events. r=morgan

https://hg.mozilla.org/mozilla-central/rev/319d295b5294

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Depends on: 1655784
Flags: needinfo?(eitan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: